scsi: ufs: core: Rename ufshcd_wb_presrv_usrspc_keep_vcc_on()

The ufshcd_wb_presrv_usrspc_keep_vcc_on() function has deviated from its
original implementation. The "_keep_vcc_on" part of the function name is
misleading. Rename the function to ufshcd_wb_curr_buff_threshold_check()
to improve the readability. Also, updated the comments in the function.
There is no change to the functionality.

Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Link: https://lore.kernel.org/r/02ae5e133f6ebf23b54d943e6d1d9de2544eb80e.1743192926.git.quic_nguyenb@quicinc.com
Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 3288a7da73dc70fb1f6bb08ff92d50deb2240bab..f317232433f9390d99c3648fce60f4275cb06d92 100644 (file)
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6068,7 +6068,7 @@ int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable)
        return ret;
 }
 
-static bool ufshcd_wb_presrv_usrspc_keep_vcc_on(struct ufs_hba *hba,
+static bool ufshcd_wb_curr_buff_threshold_check(struct ufs_hba *hba,
                                                u32 avail_buf)
 {
        u32 cur_buf;
@@ -6150,15 +6150,13 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba)
        }
 
        /*
-        * The ufs device needs the vcc to be ON to flush.
         * With user-space reduction enabled, it's enough to enable flush
         * by checking only the available buffer. The threshold
         * defined here is > 90% full.
         * With user-space preserved enabled, the current-buffer
         * should be checked too because the wb buffer size can reduce
         * when disk tends to be full. This info is provided by current
-        * buffer (dCurrentWriteBoosterBufferSize). There's no point in
-        * keeping vcc on when current buffer is empty.
+        * buffer (dCurrentWriteBoosterBufferSize).
         */
        index = ufshcd_wb_get_query_index(hba);
        ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
@@ -6173,7 +6171,7 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba)
        if (!hba->dev_info.b_presrv_uspc_en)
                return avail_buf <= UFS_WB_BUF_REMAIN_PERCENT(10);
 
-       return ufshcd_wb_presrv_usrspc_keep_vcc_on(hba, avail_buf);
+       return ufshcd_wb_curr_buff_threshold_check(hba, avail_buf);
 }
 
 static void ufshcd_rpm_dev_flush_recheck_work(struct work_struct *work)