remoteproc: k3-dsp: Suppress duplicate error message in .remove()

When the remove callback returns non-zero, the driver core emits an
error message about the error value being ignored. As the driver already
emits an error message already, return zero. This has no effect apart
from suppressing the core's message. The platform device gets unbound
irrespective of the return value.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231123211657.518181-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index ef8415a7cd542d065c13bc704ddafe7d03b2bd71..40a5fd8763faf678b2640f4ffb75a5f1e5d4288d 100644 (file)
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -835,8 +835,9 @@ static int k3_dsp_rproc_remove(struct platform_device *pdev)
        if (rproc->state == RPROC_ATTACHED) {
                ret = rproc_detach(rproc);
                if (ret) {
+                       /* Note this error path leaks resources */
                        dev_err(dev, "failed to detach proc, ret = %d\n", ret);
-                       return ret;
+                       return 0;
                }
        }