Respip dereference after NULL check.

git-svn-id: file:///svn/unbound/trunk@4101 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index 40bf83ab90c9144159c6b1c031cdd09a03b1dae7..cbcb2cb6f376ae5eb5b4cebb20b28f5e6b791355 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,6 +1,7 @@
 10 April 2017: Ralph
-       - Remove ECS option after REFUSED answer
-       - Fix small memory leak in edns_opt_copy_alloc
+       - Remove ECS option after REFUSED answer.
+       - Fix small memory leak in edns_opt_copy_alloc.
+       - Respip dereference after NULL check.
 
 7 April 2017: George
        - Fix pythonmod for cb changes.

diff --git a/respip/respip.c b/respip/respip.c
index f1a609f13fe831b185738521b1732e2bbbee2d12..d7132511122a33258fb6a8c597c5aee18631586c 100644 (file)
--- a/respip/respip.c
+++ b/respip/respip.c
@@ -125,11 +125,11 @@ respip_find_or_create(struct respip_set* set, const char* ipstr, int create)
        node = (struct resp_addr*)addr_tree_find(&set->ip_tree, &addr, addrlen, net);
        if(!node && create) {
                node = regional_alloc_zero(set->region, sizeof(*node));
-               node->action = respip_none;
                if(!node) {
                        log_err("out of memory");
                        return NULL;
                }
+               node->action = respip_none;
                if(!addr_tree_insert(&set->ip_tree, &node->node, &addr,
                        addrlen, net)) {
                        /* We know we didn't find it, so this should be