]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: raid-stripe-tree: remove unnecessary call to btrfs_mark_buffer_dirty()
authorFilipe Manana <fdmanana@suse.com>
Wed, 18 Dec 2024 12:52:28 +0000 (12:52 +0000)
committerDavid Sterba <dsterba@suse.com>
Mon, 13 Jan 2025 13:53:20 +0000 (14:53 +0100)
The call to btrfs_mark_buffer_dirty() at update_raid_extent_item() is not
necessary as we have a path setup for writing with btrfs_search_slot()
having a 'cow' argument set to 1.

This just makes the code more verbose, confusing and add a little extra
overhead and well as increase the module's text size, so remove it.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/raid-stripe-tree.c

index 45b823a0913aea5fdaab91a80e79d253a66bb700..0bf3c032d9dc43eefe158e430813add9292c577e 100644 (file)
@@ -169,7 +169,6 @@ static int update_raid_extent_item(struct btrfs_trans_handle *trans,
 
        write_extent_buffer(leaf, stripe_extent, btrfs_item_ptr_offset(leaf, slot),
                            item_size);
-       btrfs_mark_buffer_dirty(trans, leaf);
        btrfs_free_path(path);
 
        return ret;