thermal: int340x: Clean up unnecessary acpi_buffer pointer freeing

It is the caller's responsibility to free only upon ACPI_SUCCESS.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Acked-by: Zhang Rui <rui.zhang@intel.com>
[ rjw: Subject edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index 4954800b9850256da3eb6c1544594f2aa2d919d5..0e7931c286ec9aec75980e5ede93948202100917 100644 (file)
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -186,11 +186,11 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab
                ret = *((u32 *)(context.ret.pointer + 4));
                if (ret != *enable)
                        result = -EPERM;
+
+               kfree(context.ret.pointer);
        } else
                result = -EPERM;
 
-       kfree(context.ret.pointer);
-
        return result;
 }