]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ag71xx: support probe defferal for getting MAC address
authorRosen Penev <rosenp@gmail.com>
Sat, 24 Aug 2024 20:02:37 +0000 (13:02 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Aug 2024 21:19:09 +0000 (14:19 -0700)
Currently, of_get_ethdev_address() return is checked for any return error
code which means that trying to get the MAC from NVMEM cells that is backed
by MTD will fail if it was not probed before ag71xx.

So, lets check the return error code for EPROBE_DEFER and defer the ag71xx
probe in that case until the underlying NVMEM device is live.

Signed-off-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20240824200249.137209-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c

index bf02bea03a7bef188933b722ab1c314e47c81787..543cbea47138a11bb4c644d6389d5851dad0a022 100644 (file)
@@ -1895,6 +1895,8 @@ static int ag71xx_probe(struct platform_device *pdev)
        ag->stop_desc->next = (u32)ag->stop_desc_dma;
 
        err = of_get_ethdev_address(np, ndev);
+       if (err == -EPROBE_DEFER)
+               return err;
        if (err) {
                netif_err(ag, probe, ndev, "invalid MAC address, using random address\n");
                eth_hw_addr_random(ndev);