]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/selftest: Use variable for test env rather than hardcoding
authorNoel Power <noel.power@suse.com>
Fri, 13 Dec 2019 12:14:17 +0000 (12:14 +0000)
committerRalph Boehme <slow@samba.org>
Fri, 3 Apr 2020 15:08:31 +0000 (15:08 +0000)
This change makes it easier and clearer in following commits
to make specific changes based on test name.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/selftest/tests.py

index e1ed0c0defba2aa7f482d591e92af81ac417ab2e..36073724868bbe73633e9b01ec49cb8b2b018638 100755 (executable)
@@ -710,8 +710,9 @@ for t in tests:
     elif t == "smb2.change_notify_disabled":
         plansmbtorture4testsuite(t, "simpleserver", '//$SERVER/tmp -U$USERNAME%$PASSWORD')
     elif t == "smb2.notify" or t == "raw.notify" or t == "smb2.oplock" or t == "raw.oplock":
+        tmp_env = "nt4_dc"
         # These tests are a little slower so don't duplicate them with ad_dc
-        plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD --signing=required')
+        plansmbtorture4testsuite(t, tmp_env, '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD --signing=required')
     elif t == "smb2.dosmode":
         plansmbtorture4testsuite(t, "simpleserver", '//$SERVER/dosmode -U$USERNAME%$PASSWORD')
     elif t == "smb2.kernel-oplocks":