]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: imx8qxp-pixel-combiner: Switch to RUNTIME_PM_OPS()
authorFabio Estevam <festevam@denx.de>
Wed, 26 Jun 2024 23:07:01 +0000 (20:07 -0300)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 13 Sep 2024 08:10:16 +0000 (10:10 +0200)
Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative.

The combined usage of pm_ptr() and RUNTIME_PM_OPS()
allows the compiler to evaluate if the runtime suspend/resume() functions
are used at build time or are simply dead code.

This allows removing the __maybe_unused notation from the runtime
suspend/resume() functions.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240626230704.708234-3-festevam@gmail.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240626230704.708234-3-festevam@gmail.com
drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c

index e6dbbdc87ce29f4c9ea5767d5f77d176043ca5f6..ce43e4069e21b2ecfae2f885fe2dab002a277f22 100644 (file)
@@ -371,7 +371,7 @@ static void imx8qxp_pc_bridge_remove(struct platform_device *pdev)
        pm_runtime_disable(&pdev->dev);
 }
 
-static int __maybe_unused imx8qxp_pc_runtime_suspend(struct device *dev)
+static int imx8qxp_pc_runtime_suspend(struct device *dev)
 {
        struct platform_device *pdev = to_platform_device(dev);
        struct imx8qxp_pc *pc = platform_get_drvdata(pdev);
@@ -393,7 +393,7 @@ static int __maybe_unused imx8qxp_pc_runtime_suspend(struct device *dev)
        return ret;
 }
 
-static int __maybe_unused imx8qxp_pc_runtime_resume(struct device *dev)
+static int imx8qxp_pc_runtime_resume(struct device *dev)
 {
        struct platform_device *pdev = to_platform_device(dev);
        struct imx8qxp_pc *pc = platform_get_drvdata(pdev);
@@ -415,8 +415,7 @@ static int __maybe_unused imx8qxp_pc_runtime_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops imx8qxp_pc_pm_ops = {
-       SET_RUNTIME_PM_OPS(imx8qxp_pc_runtime_suspend,
-                          imx8qxp_pc_runtime_resume, NULL)
+       RUNTIME_PM_OPS(imx8qxp_pc_runtime_suspend, imx8qxp_pc_runtime_resume, NULL)
 };
 
 static const struct of_device_id imx8qxp_pc_dt_ids[] = {
@@ -430,7 +429,7 @@ static struct platform_driver imx8qxp_pc_bridge_driver = {
        .probe  = imx8qxp_pc_bridge_probe,
        .remove_new = imx8qxp_pc_bridge_remove,
        .driver = {
-               .pm = &imx8qxp_pc_pm_ops,
+               .pm = pm_ptr(&imx8qxp_pc_pm_ops),
                .name = DRIVER_NAME,
                .of_match_table = imx8qxp_pc_dt_ids,
        },