]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: mlxsw: rtnetlink: Use devlink_reload() API
authorAmit Cohen <amcohen@nvidia.com>
Mon, 30 Sep 2024 15:12:50 +0000 (17:12 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 23:43:44 +0000 (16:43 -0700)
The test runs "devlink reload" explicitly. Instead, it is better to use
devlink_reload() which waits for udev events to be processed. Do not sleep
after reload, as devlink_reload() blocks until all the netdevs are renamed.

Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/844509e3057b65277a7181a23c95b71ec95e8a56.1727706741.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh

index 893a693ad805766addc8ea0c95fb09760721c98c..45a56961842404b4b7e767f815c3055c9b348666 100755 (executable)
@@ -186,10 +186,7 @@ bridge_vlan_flags_test()
 
        # If we did not handle references correctly, then this should produce a
        # trace
-       devlink dev reload "$DEVLINK_DEV"
-
-       # Allow netdevices to be re-created following the reload
-       sleep 20
+       devlink_reload
 
        log_test "bridge vlan flags"
 }
@@ -923,12 +920,9 @@ devlink_reload_test()
        # devlink reload can be performed without errors
        RET=0
 
-       devlink dev reload "$DEVLINK_DEV"
-       check_err $? "devlink reload failed"
+       devlink_reload
 
        log_test "devlink reload - last test"
-
-       sleep 20
 }
 
 trap cleanup EXIT