]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: pp-bench: remove page_pool_put_page wrapper
authorMina Almasry <almasrymina@google.com>
Fri, 27 Jun 2025 20:04:52 +0000 (20:04 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Jul 2025 00:42:11 +0000 (17:42 -0700)
Minor cleanup: remove the pointless looking _ wrapper around
page_pool_put_page, and just do the call directly.

Signed-off-by: Mina Almasry <almasrymina@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Link: https://patch.msgid.link/20250627200501.1712389-2-almasrymina@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c

index 1cd3157fb6a9d98265bfc5a59d485d33d4a63272..cb6468adbda4d20505b623ebb87f03792a12ee69 100644 (file)
 static int verbose = 1;
 #define MY_POOL_SIZE 1024
 
-static void _page_pool_put_page(struct page_pool *pool, struct page *page,
-                               bool allow_direct)
-{
-       page_pool_put_page(pool, page, -1, allow_direct);
-}
-
 /* Makes tests selectable. Useful for perf-record to analyze a single test.
  * Hint: Bash shells support writing binary number like: $((2#101010)
  *
@@ -121,7 +115,7 @@ static void pp_fill_ptr_ring(struct page_pool *pp, int elems)
        for (i = 0; i < elems; i++)
                array[i] = page_pool_alloc_pages(pp, gfp_mask);
        for (i = 0; i < elems; i++)
-               _page_pool_put_page(pp, array[i], false);
+               page_pool_put_page(pp, array[i], -1, false);
 
        kfree(array);
 }
@@ -180,14 +174,14 @@ static int time_bench_page_pool(struct time_bench_record *rec, void *data,
 
                } else if (type == type_ptr_ring) {
                        /* Normal return path */
-                       _page_pool_put_page(pp, page, false);
+                       page_pool_put_page(pp, page, -1, false);
 
                } else if (type == type_page_allocator) {
                        /* Test if not pages are recycled, but instead
                         * returned back into systems page allocator
                         */
                        get_page(page); /* cause no-recycling */
-                       _page_pool_put_page(pp, page, false);
+                       page_pool_put_page(pp, page, -1, false);
                        put_page(page);
                } else {
                        BUILD_BUG();