]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: change virDomainDefMaybeAddVirtioSerialController() to return void
authorLaine Stump <laine@redhat.com>
Wed, 12 Feb 2025 03:53:30 +0000 (22:53 -0500)
committerLaine Stump <laine@redhat.com>
Wed, 5 Mar 2025 21:56:45 +0000 (16:56 -0500)
It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/domain_conf.c

index ec72bb511799154eb01a0b15e1cb451843121ce3..64ec5205894ec196fa92cb2f26049f1c80ce13e9 100644 (file)
@@ -22275,7 +22275,7 @@ virDomainDefAddDiskControllersForType(virDomainDef *def,
 }
 
 
-static int
+static void
 virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
 {
     /* Look for any virtio serial or virtio console devs */
@@ -22304,8 +22304,6 @@ virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
             virDomainDefMaybeAddController(def, VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL, idx, -1);
         }
     }
-
-    return 0;
 }
 
 
@@ -22362,8 +22360,7 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
     virDomainDefAddDiskControllersForType(def, VIR_DOMAIN_CONTROLLER_TYPE_SATA,
                                           VIR_DOMAIN_DISK_BUS_SATA);
 
-    if (virDomainDefMaybeAddVirtioSerialController(def) < 0)
-        return -1;
+    virDomainDefMaybeAddVirtioSerialController(def);
 
     if (virDomainDefMaybeAddSmartcardController(def) < 0)
         return -1;