]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clocksource: Print clocksource name when clocksource is tested unstable
authorYunying Sun <yunying.sun@intel.com>
Wed, 16 Nov 2022 08:22:21 +0000 (16:22 +0800)
committerPaul E. McKenney <paulmck@kernel.org>
Wed, 4 Jan 2023 04:43:45 +0000 (20:43 -0800)
Some "TSC fall back to HPET" messages appear on systems having more than
2 NUMA nodes:

clocksource: timekeeping watchdog on CPU168: hpet read-back delay of 4296200ns, attempt 4, marking unstable

The "hpet" here is misleading the clocksource watchdog is really
doing repeated reads of "hpet" in order to check for unrelated delays.
Therefore, print the name of the clocksource under test, prefixed by
"wd-" and suffixed by "-wd", for example, "wd-tsc-wd".

Signed-off-by: Yunying Sun <yunying.sun@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/time/clocksource.c

index 9cf32ccda715dc33bb34cb731b58455654e43b40..4a2c3bb92e2e99c917faa3441876aa610ec22446 100644 (file)
@@ -257,8 +257,8 @@ static enum wd_read_status cs_watchdog_read(struct clocksource *cs, u64 *csnow,
                        goto skip_test;
        }
 
-       pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n",
-               smp_processor_id(), watchdog->name, wd_delay, nretries);
+       pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldns, attempt %d, marking unstable\n",
+               smp_processor_id(), cs->name, wd_delay, nretries);
        return WD_READ_UNSTABLE;
 
 skip_test: