]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Clear async job when p2p migration fails early
authorJiri Denemark <jdenemar@redhat.com>
Wed, 17 Oct 2012 12:08:17 +0000 (14:08 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 17 Oct 2012 15:04:45 +0000 (17:04 +0200)
When p2p migration fails early because qemuMigrationIsAllowed or
qemuMigrationIsSafe say migration should be cancelled, we fail to clear
the migration-out async job. As a result of that, further APIs called
for the same domain may fail with Timed out during operation: cannot
acquire state change lock.

Reported by Guido Winkelmann.

Conflicts:
src/qemu/qemu_migration.c - qemuMigrationIsSafe was not there in
                            0.9.6 yet

src/qemu/qemu_migration.c

index 56d4ecfb98034918226ac8cc544d82d4be9f6e73..de5f6d84861a0993c4d0f52e775d96402d180964 100644 (file)
@@ -2219,7 +2219,7 @@ qemuMigrationPerformJob(struct qemud_driver *driver,
     }
 
     if (!qemuMigrationIsAllowed(driver, vm, NULL))
-        goto cleanup;
+        goto endjob;
 
     resume = virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING;