]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ice: check correct pointer in fwlog debugfs
authorMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tue, 24 Jun 2025 09:26:36 +0000 (11:26 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 15 Jul 2025 20:01:16 +0000 (13:01 -0700)
pf->ice_debugfs_pf_fwlog should be checked for an error here.

Fixes: 96a9a9341cda ("ice: configure FW logging")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_debugfs.c

index 9fc0fd95a13d8f2c40475a94f38d3a2c088ab6f4..cb71eca6a85bf623f2aa18c80b3b3edd4311232b 100644 (file)
@@ -606,7 +606,7 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf)
 
        pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog",
                                                      pf->ice_debugfs_pf);
-       if (IS_ERR(pf->ice_debugfs_pf))
+       if (IS_ERR(pf->ice_debugfs_pf_fwlog))
                goto err_create_module_files;
 
        fw_modules_dir = debugfs_create_dir("modules",