]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Fix the Coverity workflow after the Quiche installation refactoring 14579/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 22 Aug 2024 12:37:14 +0000 (14:37 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 22 Aug 2024 13:45:06 +0000 (15:45 +0200)
.github/workflows/misc-dailies.yml
tasks.py

index 5840075d82c2570f77949e39ef4d79acbe6846e6..48eee9caf1a8c987ae612e0d98b7a508d09b3ace 100644 (file)
@@ -93,6 +93,8 @@ jobs:
       - run: inv coverity-clang-configure
       - run: inv ci-autoconf
         working-directory: ./pdns/dnsdistdist/
+      - run: inv ci-install-rust ${{ env.REPO_HOME }}
+        working-directory: ./pdns/dnsdistdist/
       - run: inv ci-build-and-install-quiche ${{ env.REPO_HOME }}
         working-directory: ./pdns/dnsdistdist/
       - run: inv ci-dnsdist-configure full
index 65c58d0d14f118989a3b30b7ab1c869870b6bbc8..f2b00d5a0a1cafe611e7a206c6f4adf5b4e30e93 100644 (file)
--- a/tasks.py
+++ b/tasks.py
@@ -1049,6 +1049,9 @@ def coverity_upload(c, email, project, tarball):
 @task
 def ci_build_and_install_quiche(c, repo):
     with c.cd(f'{repo}/builder-support/helpers/'):
+        # be careful that rust needs to have been installed system-wide,
+        # as the one installed in GitHub actions' Ubuntu images in /home/runner/.cargo/bin/cargo
+        # is not in the path for the root user (and shouldn't be)
         c.run(f'sudo {repo}/builder-support/helpers/install_quiche.sh')
 
     # cannot use c.sudo() inside a cd() context, see https://github.com/pyinvoke/invoke/issues/687