]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 May 2023 16:56:27 +0000 (17:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 May 2023 16:56:27 +0000 (17:56 +0100)
added patches:
3c589_cs-fix-an-error-handling-path-in-tc589_probe.patch

queue-4.19/3c589_cs-fix-an-error-handling-path-in-tc589_probe.patch [new file with mode: 0644]
queue-4.19/series

diff --git a/queue-4.19/3c589_cs-fix-an-error-handling-path-in-tc589_probe.patch b/queue-4.19/3c589_cs-fix-an-error-handling-path-in-tc589_probe.patch
new file mode 100644 (file)
index 0000000..593b0fd
--- /dev/null
@@ -0,0 +1,49 @@
+From 640bf95b2c7c2981fb471acdafbd3e0458f8390d Mon Sep 17 00:00:00 2001
+From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
+Date: Sat, 20 May 2023 11:48:55 +0200
+Subject: 3c589_cs: Fix an error handling path in tc589_probe()
+
+From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
+
+commit 640bf95b2c7c2981fb471acdafbd3e0458f8390d upstream.
+
+Should tc589_config() fail, some resources need to be released as already
+done in the remove function.
+
+Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
+Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
+Reviewed-by: Simon Horman <simon.horman@corigine.com>
+Link: https://lore.kernel.org/r/d8593ae867b24c79063646e36f9b18b0790107cb.1684575975.git.christophe.jaillet@wanadoo.fr
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/3com/3c589_cs.c |   11 ++++++++++-
+ 1 file changed, 10 insertions(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/3com/3c589_cs.c
++++ b/drivers/net/ethernet/3com/3c589_cs.c
+@@ -196,6 +196,7 @@ static int tc589_probe(struct pcmcia_dev
+ {
+       struct el3_private *lp;
+       struct net_device *dev;
++      int ret;
+       dev_dbg(&link->dev, "3c589_attach()\n");
+@@ -219,7 +220,15 @@ static int tc589_probe(struct pcmcia_dev
+       dev->ethtool_ops = &netdev_ethtool_ops;
+-      return tc589_config(link);
++      ret = tc589_config(link);
++      if (ret)
++              goto err_free_netdev;
++
++      return 0;
++
++err_free_netdev:
++      free_netdev(dev);
++      return ret;
+ }
+ static void tc589_detach(struct pcmcia_device *link)
index 4ca82ad737355392d75f7095f23e1b874b7ea416..832068541826425aeae78c6320452a26e1660ffd 100644 (file)
@@ -129,3 +129,4 @@ xen-pvcalls-back-fix-double-frees-with-pvcalls_new_active_socket.patch
 x86-show_trace_log_lvl-ensure-stack-pointer-is-aligned-again.patch
 asoc-intel-skylake-fix-declaration-of-enum-skl_ch_cfg.patch
 forcedeth-fix-an-error-handling-path-in-nv_probe.patch
+3c589_cs-fix-an-error-handling-path-in-tc589_probe.patch