]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: phy: micrel: Fix lan8814_config_init
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Thu, 25 Sep 2025 06:47:02 +0000 (08:47 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Sep 2025 00:32:04 +0000 (17:32 -0700)
The blamed commit introduced the function lanphy_modify_page_reg which
as name suggests it, it modifies the registers. In the same commit we
have started to use this function inside the drivers. The problem is
that in the function lan8814_config_init we passed the wrong page number
when disabling the aneg towards host side. We passed extended page number
4(LAN8814_PAGE_COMMON_REGS) instead of extended page
5(LAN8814_PAGE_PORT_REGS)

Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250925064702.3906950-1-horatiu.vultur@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/micrel.c

index 0b42400e5e098050e44b8ae8d2be5c0ee4ef11ed..79ce3eb6752b6d8609b2f7bcc670f7d7b65be452 100644 (file)
@@ -4367,7 +4367,7 @@ static int lan8814_config_init(struct phy_device *phydev)
                               LAN8814_QSGMII_SOFT_RESET_BIT);
 
        /* Disable ANEG with QSGMII PCS Host side */
-       lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
+       lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
                               LAN8814_QSGMII_PCS1G_ANEG_CONFIG,
                               LAN8814_QSGMII_PCS1G_ANEG_CONFIG_ANEG_ENA,
                               0);