]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8712: remove unused drvinfo_sz from update_recvframe_attrib
authorPing-Ke Shih <pkshih@realtek.com>
Fri, 13 Sep 2024 00:28:12 +0000 (08:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Sep 2024 05:31:55 +0000 (07:31 +0200)
The drvinfo_sz is a size of hardware generated data putting in front of
real RX data. The functions r8712_rxcmd_event_hdl() and recvbuf2recvframe()
have its own parsing code to get drvinfo_sz to access real RX data, so
removing this unused drvinfo_sz is safe.

Otherwise, clang report:

rtl8712_recv.c:139:6: warning:
variable 'drvinfo_sz' set but not used [-Wunused-but-set-variable]
  139 |         u16 drvinfo_sz;
      |             ^

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240913002815.5149-2-pkshih@realtek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl8712_recv.c

index 1fabc5137a4cb0410bfca522d9c43256a70466ab..ab344d676bb94665ac57e8d74a27f7283b8a781a 100644 (file)
@@ -136,10 +136,6 @@ void r8712_free_recvframe(union recv_frame *precvframe,
 static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib,
                                                  struct recv_stat *prxstat)
 {
-       u16 drvinfo_sz;
-
-       drvinfo_sz = (le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16;
-       drvinfo_sz <<= 3;
        /*TODO:
         * Offset 0
         */