]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: fastrpc: Avoid updating PD type for capability request
authorEkansh Gupta <quic_ekangupt@quicinc.com>
Fri, 28 Jun 2024 11:44:58 +0000 (12:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2024 14:17:53 +0000 (16:17 +0200)
When user is requesting for DSP capability, the process pd type is
getting updated to USER_PD which is incorrect as DSP will assume the
process which is making the request is a user PD and this will never
get updated back to the original value. The actual PD type should not
be updated for capability request and it should be serviced by the
respective PD on DSP side. Don't change process's PD type for DSP
capability request.

Fixes: 6c16fd8bdd40 ("misc: fastrpc: Add support to get DSP capabilities")
Cc: stable <stable@kernel.org>
Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240628114501.14310-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/fastrpc.c

index 30b93012877fc61b74e51861401d8f844ddd54fa..3fef3eecb88c0f164316a03e28b2dac4cb5068bd 100644 (file)
@@ -1707,7 +1707,6 @@ static int fastrpc_get_info_from_dsp(struct fastrpc_user *fl, uint32_t *dsp_attr
        args[1].ptr = (u64)(uintptr_t)&dsp_attr_buf[1];
        args[1].length = dsp_attr_buf_len * sizeof(u32);
        args[1].fd = -1;
-       fl->pd = USER_PD;
 
        return fastrpc_internal_invoke(fl, true, FASTRPC_DSP_UTILITIES_HANDLE,
                                       FASTRPC_SCALARS(0, 1, 1), args);