staging: rtl8723bs: propagate errno through hal xmit path

Propagate errno values from rtl8723bs_hal_xmitframe_enqueue()
through rtw_hal_xmitframe_enqueue() by returning the error code
directly.

Update rtw_hal_xmit() to explicitly map the boolean return
value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying
the return semantics at the HAL boundary.

None of the callers of rtw_hal_xmitframe_enqueue() check the
return value, so they do not need to be updated. This change
does not affect runtime behavior.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Link: https://patch.msgid.link/20260514100708.25031-6-dennylin0707@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 19e16270381e35eb22d48c3b0514ae58c595f215..9a3ebad35efc047ecb18138b1199c0678feb4fa8 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -99,14 +99,17 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter)
        return CheckIPSStatus(padapter);
 }
 
-s32    rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe)
+int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe)
 {
        return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe);
 }
 
 s32    rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe)
 {
-       return rtl8723bs_hal_xmit(padapter, pxmitframe);
+       if (rtl8723bs_hal_xmit(padapter, pxmitframe))
+               return _FAIL;
+
+       return _SUCCESS;
 }
 
 /*

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index f4f3632f0646d8e9876ef916679a6746cf5c21af..e40f69c13c44fd2b4d9c0660a6bc32cb23831c89 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -512,7 +512,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue(
                complete(&pxmitpriv->SdioXmitStart);
        }
 
-       return err ? _FAIL : _SUCCESS;
+       return err;
 
 }
 

diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 9b000681ff80fdf5c3468098aa35f29fa6a3db5c..ee8ad26325b5db11f0542b5a5d9d378bd2afbae2 100644 (file)
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -195,7 +195,7 @@ void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariab
 
 u8 rtw_hal_check_ips_status(struct adapter *padapter);
 
-s32    rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe);
+int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe);
 s32    rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);
 s32    rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe);