]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib:async_req: Initialize variables
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Sun, 18 May 2025 22:31:47 +0000 (10:31 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 27 Aug 2025 03:41:36 +0000 (03:41 +0000)
../../lib/async_req/async_sock.c: In function ‘writev_do’:
../../lib/async_req/async_sock.c:360:12: error: ‘written’ may be used uninitialized [-Werror=maybe-uninitialized]
  360 |         if ((written == -1) &&
      |            ^
../../lib/async_req/async_sock.c:343:17: note: ‘written’ was declared here
  343 |         ssize_t written;
      |                 ^~~~~~~
../../lib/async_req/async_sock.c: In function ‘read_packet_do’:
../../lib/async_req/async_sock.c:563:12: error: ‘nread’ may be used uninitialized [-Werror=maybe-uninitialized]
  563 |         if ((nread == -1) && (errno == EINTR)) {
      |            ^
../../lib/async_req/async_sock.c:531:17: note: ‘nread’ was declared here
  531 |         ssize_t nread, more;
      |                 ^~~~~
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
lib/async_req/async_sock.c

index e90619056ed9e7010ba49483bc3d6081ed7d8014..b25d4cc373157e8a3f8204ee3a533f13a6dfca29 100644 (file)
@@ -439,7 +439,7 @@ static bool writev_cancel(struct tevent_req *req)
 
 static void writev_do(struct tevent_req *req, struct writev_state *state)
 {
-       ssize_t written;
+       ssize_t written = -1;
        bool ok;
 
        if (state->is_sock) {
@@ -627,7 +627,7 @@ static void read_packet_do(struct tevent_req *req,
        struct read_packet_state *state =
                tevent_req_data(req, struct read_packet_state);
        size_t total;
-       ssize_t nread, more;
+       ssize_t nread = -1, more;
        uint8_t *tmp;
 
 retry: