Silence compiler warnings from some older compilers.

Since a117cebd6, some older gcc versions issue "variable may be used
uninitialized in this function" complaints for brin_summarize_range.
Silence that using the same coding pattern as in bt_index_check_internal;
arguably, a117cebd6 had too narrow a view of which compilers might give
trouble.

Nathan Bossart and Tom Lane.  Back-patch as the previous commit was.

Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13

diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index 29b4170a7eb055dc9f85c1fcfb7a88526957a5dd..7211ce72d08c5dd7583278b569559e77ed09f736 100644 (file)
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -199,7 +199,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck)
        else
        {
                heaprel = NULL;
-               /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+               /* Set these just to suppress "uninitialized variable" warnings */
                save_userid = InvalidOid;
                save_sec_context = -1;
                save_nestlevel = -1;

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index fdedb6252bf6f4880b7839710425c689c7b675a8..6e88871d9e82486883b78fd78c292e7ea9222366 100644 (file)
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -913,7 +913,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
                save_nestlevel = NewGUCNestLevel();
        }
        else
+       {
                heapRel = NULL;
+               /* Set these just to suppress "uninitialized variable" warnings */
+               save_userid = InvalidOid;
+               save_sec_context = -1;
+               save_nestlevel = -1;
+       }
 
        indexRel = index_open(indexoid, ShareUpdateExclusiveLock);