]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_repair: don't obliterate return codes
authorDarrick J. Wong <djwong@kernel.org>
Thu, 16 Jan 2025 21:22:03 +0000 (13:22 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 16 Jan 2025 21:27:27 +0000 (13:27 -0800)
Don't clobber error here, it's err2 that's the temporary variable.

Coverity-id: 1637363
Fixes: b790ab2a303d58 ("xfs_repair: support quota inodes in the metadata directory")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
repair/quotacheck.c

index 8c7339b267d8e602a9b9257f5fa5c50cff9bc22f..7953144c3f416bf96d0a37ec3064d5dac709cfad 100644 (file)
@@ -691,7 +691,7 @@ discover_quota_inodes(
        err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_GROUP);
        if (err2 && !error)
                error = err2;
-       error = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
+       err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
        if (err2 && !error)
                error = err2;