]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_dependencies()
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 14:43:26 +0000 (15:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 19 Feb 2025 15:59:14 +0000 (16:59 +0100)
drm_atomic_helper_wait_for_dependencies() waits for all the dependencies
a commit has before going forward with it. It takes the drm_atomic_state
being committed as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-7-e71598f49c8f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_atomic_helper.c

index f8ab33fec5d02ca23929f624032086288de97f87..512f10c4b6aaf21b44711e7f99c682cc15587212 100644 (file)
@@ -2423,17 +2423,17 @@ EXPORT_SYMBOL(drm_atomic_helper_setup_commit);
 
 /**
  * drm_atomic_helper_wait_for_dependencies - wait for required preceding commits
- * @old_state: atomic state object with old state structures
+ * @state: atomic state object being committed
  *
  * This function waits for all preceding commits that touch the same CRTC as
- * @old_state to both be committed to the hardware (as signalled by
+ * @state to both be committed to the hardware (as signalled by
  * drm_atomic_helper_commit_hw_done()) and executed by the hardware (as signalled
  * by calling drm_crtc_send_vblank_event() on the &drm_crtc_state.event).
  *
  * This is part of the atomic helper support for nonblocking commits, see
  * drm_atomic_helper_setup_commit() for an overview.
  */
-void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *old_state)
+void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *state)
 {
        struct drm_crtc *crtc;
        struct drm_crtc_state *old_crtc_state;
@@ -2444,7 +2444,7 @@ void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *old_state)
        int i;
        long ret;
 
-       for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
+       for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) {
                ret = drm_crtc_commit_wait(old_crtc_state->commit);
                if (ret)
                        drm_err(crtc->dev,
@@ -2452,7 +2452,7 @@ void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *old_state)
                                crtc->base.id, crtc->name);
        }
 
-       for_each_old_connector_in_state(old_state, conn, old_conn_state, i) {
+       for_each_old_connector_in_state(state, conn, old_conn_state, i) {
                ret = drm_crtc_commit_wait(old_conn_state->commit);
                if (ret)
                        drm_err(conn->dev,
@@ -2460,7 +2460,7 @@ void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *old_state)
                                conn->base.id, conn->name);
        }
 
-       for_each_old_plane_in_state(old_state, plane, old_plane_state, i) {
+       for_each_old_plane_in_state(state, plane, old_plane_state, i) {
                ret = drm_crtc_commit_wait(old_plane_state->commit);
                if (ret)
                        drm_err(plane->dev,