]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
block: remove test of incorrect io priority level
authorAaron Lu <ziqianlu@bytedance.com>
Thu, 8 May 2025 08:30:36 +0000 (16:30 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 May 2025 15:04:12 +0000 (09:04 -0600)
Ever since commit eca2040972b4("scsi: block: ioprio: Clean up interface
definition"), the macro IOPRIO_PRIO_LEVEL() will mask the level value to
something between 0 and 7 so necessarily, level will always be lower than
IOPRIO_NR_LEVELS(8).

Remove this obsolete check.

Reported-by: Kexin Wei <ys.weikexin@h3c.com>
Cc: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Aaron Lu <ziqianlu@bytedance.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250508083018.GA769554@bytedance
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/ioprio.c

index 73301a261429ff9e04a166aefa5c72df55eaee57..f0ee2798539c0141732cd4712a0225dbbcbeb2ac 100644 (file)
@@ -46,12 +46,8 @@ int ioprio_check_cap(int ioprio)
                         */
                        if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_NICE))
                                return -EPERM;
-                       fallthrough;
-                       /* rt has prio field too */
-               case IOPRIO_CLASS_BE:
-                       if (level >= IOPRIO_NR_LEVELS)
-                               return -EINVAL;
                        break;
+               case IOPRIO_CLASS_BE:
                case IOPRIO_CLASS_IDLE:
                        break;
                case IOPRIO_CLASS_NONE: