net: mana: Use pci_name() for debugfs directory naming

Use pci_name(pdev) for the per-device debugfs directory instead of
hardcoded "0" for PFs and pci_slot_name(pdev->slot) for VFs. The
previous approach had two issues:

1. pci_slot_name() dereferences pdev->slot, which can be NULL for VFs
   in environments like generic VFIO passthrough or nested KVM,
   causing a NULL pointer dereference.

2. Multiple PFs would all use "0", and VFs across different PCI
   domains or buses could share the same slot name, leading to
   -EEXIST errors from debugfs_create_dir().

pci_name(pdev) returns the unique BDF address, is always valid, and is
unique across the system.

Fixes: 6607c17c6c5e ("net: mana: Enable debugfs files for MANA device")
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260408081224.302308-2-ernis@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
index 786186c9a115f90f8cd4aedc962c13fef06cafbd..c2e855ff3ca9a809ef8704de98c20dd14abb1127 100644 (file)
--- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
+++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
@@ -2007,11 +2007,8 @@ static int mana_gd_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        gc->dev = &pdev->dev;
        xa_init(&gc->irq_contexts);
 
-       if (gc->is_pf)
-               gc->mana_pci_debugfs = debugfs_create_dir("0", mana_debugfs_root);
-       else
-               gc->mana_pci_debugfs = debugfs_create_dir(pci_slot_name(pdev->slot),
-                                                         mana_debugfs_root);
+       gc->mana_pci_debugfs = debugfs_create_dir(pci_name(pdev),
+                                                 mana_debugfs_root);
 
        err = mana_gd_setup(pdev);
        if (err)