]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: server: Remove useless o_stream_flush() in smtp_server_connection_disconnect().
authorStephan Bosch <stephan.bosch@dovecot.fi>
Mon, 11 Dec 2017 09:41:53 +0000 (10:41 +0100)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Mon, 11 Dec 2017 13:43:30 +0000 (15:43 +0200)
This is already performed implicitly by o_stream_uncork().
Fixes a problem found by Coverity.

src/lib-smtp/smtp-server-connection.c

index 145df3e6b40a2a63a6467b04006e1c406eb44ac4..f9355258f72a642e3df30165b9a97b85931a9c9f 100644 (file)
@@ -1014,10 +1014,8 @@ smtp_server_connection_disconnect(struct smtp_server_connection *conn,
        smtp_server_connection_update_stats(conn);
 
        smtp_server_connection_timeout_stop(conn);
-       if (conn->conn.output != NULL) {
-               o_stream_flush(conn->conn.output);
+       if (conn->conn.output != NULL)
                o_stream_uncork(conn->conn.output);
-       }
        if (conn->smtp_parser != NULL)
                smtp_command_parser_deinit(&conn->smtp_parser);
        if (conn->ssl_iostream != NULL)