]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
virtio-net: Fix num_buffers for version 1
authorAkihiko Odaki <akihiko.odaki@daynix.com>
Wed, 8 Jan 2025 12:13:29 +0000 (21:13 +0900)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 2 Apr 2025 16:44:47 +0000 (12:44 -0400)
The specification says the device MUST set num_buffers to 1 if
VIRTIO_NET_F_MRG_RXBUF has not been negotiated.

Fixes: df91055db5c9 ("virtio-net: enable virtio 1.0")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20250108-buffers-v1-1-a0c85ff31aeb@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/net/virtio-net.c

index de87cfadffe18de37525f6cf2ea0dd362ef488fe..340c6b642224bca9df2b73fe4310a4c4aa251439 100644 (file)
@@ -1999,6 +1999,8 @@ static ssize_t virtio_net_receive_rcu(NetClientState *nc, const uint8_t *buf,
                                     offsetof(typeof(hdr),
                                              virtio_net.hdr.num_buffers),
                                     sizeof(hdr.virtio_net.hdr.num_buffers));
+            } else {
+                hdr.virtio_net.hdr.num_buffers = cpu_to_le16(1);
             }
 
             guest_offset = n->has_vnet_hdr ?