[Minor] Do not try to modify constant memory

diff --git a/src/libmime/mime_headers.c b/src/libmime/mime_headers.c
index 71b4f2688d0b372ecff3fb10413f613b94d8c02a..c1d5f397ccd86d9935c6872084ec6fc14b3757b4 100644 (file)
--- a/src/libmime/mime_headers.c
+++ b/src/libmime/mime_headers.c
@@ -403,7 +403,8 @@ rspamd_mime_headers_process (struct rspamd_task *task,
                        }
 
                        if (nh->decoded == NULL) {
-                               nh->decoded = "";
+                               /* As we strip comments in place... */
+                               nh->decoded = rspamd_mempool_strdup (task->task_pool, "");
                        }
 
                        /* We also validate utf8 and replace all non-valid utf8 chars */

diff --git a/test/rspamd_cxx_unit_utils.hxx b/test/rspamd_cxx_unit_utils.hxx
index 0cd229a4fc354a1aa610740b4b27856b37e7bb02..00b5e1b61a7efe2aea18c6812690dbf100b0b6bf 100644 (file)
--- a/test/rspamd_cxx_unit_utils.hxx
+++ b/test/rspamd_cxx_unit_utils.hxx
@@ -39,6 +39,7 @@ TEST_CASE("rspamd_strip_smtp_comments_inplace") {
                        {"ab(olo\\)lo)c(foo)", "abc"},
                        {"ab(trol\\\1lo)c(foo)", "abc"},
                        {"\\ab(trol\\\1lo)c(foo)", "abc"},
+                       {"", ""},
        };
 
        for (const auto &c : cases) {