Remove all the module_rlm_by_data lookup functions

diff --git a/src/lib/server/module_rlm.c b/src/lib/server/module_rlm.c
index 66e5e2e1db12bd84959ad9f144cffc6097739b8a..2d67bde3f318c59eca36698252e5e0d81b2c6c25 100644 (file)
--- a/src/lib/server/module_rlm.c
+++ b/src/lib/server/module_rlm.c
@@ -803,11 +803,6 @@ module_instance_t *module_rlm_by_name(module_instance_t const *parent, char cons
        return module_instance_by_name(rlm_modules_static, parent, asked_name);
 }
 
-module_instance_t *module_rlm_by_data(module_instance_t const *data)
-{
-       return module_instance_by_data(rlm_modules_static, data);
-}
-
 /** Create a virtual module.
  *
  * @param[in] cs       that defines the virtual module.

diff --git a/src/lib/server/module_rlm.h b/src/lib/server/module_rlm.h
index 0cb00f71f57222a825552144e8eb51dc5a45381a..7332ea3e2f301896c6ee8ee8fcc37550799d9681 100644 (file)
--- a/src/lib/server/module_rlm.h
+++ b/src/lib/server/module_rlm.h
@@ -98,8 +98,6 @@ module_thread_instance_t *module_rlm_thread_by_data(void const *data);
 
 module_instance_t      *module_rlm_by_name(module_instance_t const *parent, char const *asked_name);
 
-module_instance_t      *module_rlm_by_data(module_instance_t const *data);
-
 CONF_SECTION           *module_rlm_by_name_virtual(char const *asked_name);
 
 /** @} */

diff --git a/src/modules/rlm_mschap/rlm_mschap.c b/src/modules/rlm_mschap/rlm_mschap.c
index 395224e61ff665024bd8171d1eecc3e326874db4..f480d9a5712f708835b66707f2f4ae7cecac0e75 100644 (file)
--- a/src/modules/rlm_mschap/rlm_mschap.c
+++ b/src/modules/rlm_mschap/rlm_mschap.c
@@ -795,10 +795,9 @@ static int _mod_conn_free(struct wbcContext **wb_ctx)
 /*
  *     Create connection pool winbind context
  */
-static void *mod_conn_create(TALLOC_CTX *ctx, void *instance, UNUSED fr_time_delta_t timeout)
+static void *mod_conn_create(TALLOC_CTX *ctx, UNUSED void *instance, UNUSED fr_time_delta_t timeout)
 {
        struct wbcContext       **wb_ctx;
-       module_inst_ctx_t       *mctx =  MODULE_INST_CTX(module_rlm_by_data(instance));
 
        wb_ctx = talloc_zero(ctx, struct wbcContext *);
        *wb_ctx = wbcCtxCreate();