scheduler: Fix possible use_after_free in `cupsdReadClient()`

If `cupsdSendHeader()` fails, we free the connection and return -1, but
in that case we try to free the connection again in `cupsdReadClient()`.

diff --git a/scheduler/client.c b/scheduler/client.c
index f6166091e8df2e97cb6aea4e03d1a51e1c39743e..63844d531874eaf7b88ecd12172c542954f39c15 100644 (file)
--- a/scheduler/client.c
+++ b/scheduler/client.c
@@ -2761,10 +2761,7 @@ check_start_tls(cupsd_client_t *con)     /* I - Client connection */
     httpSetField(con->http, HTTP_FIELD_CONTENT_LENGTH, "0");
 
     if (!cupsdSendHeader(con, HTTP_STATUS_OK, NULL, CUPSD_AUTH_NONE))
-    {
-      cupsdCloseClient(con);
       return (-1);
-    }
   }
 
   return (1);