]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
Pointless to check for non-NULL pointers that already have been dereferenced
authorDaniel Stenberg <daniel@haxx.se>
Sat, 31 Mar 2007 21:10:05 +0000 (21:10 +0000)
committerDaniel Stenberg <daniel@haxx.se>
Sat, 31 Mar 2007 21:10:05 +0000 (21:10 +0000)
and they have to be non-NULL long before this check.
CID 22 in the coverity.com scan

lib/ssluse.c

index 8265f13b3d78d693044090d7a57fe001237738f3..d96ee13bf6552f772afb2b84091ada05da6eef45 100644 (file)
@@ -431,7 +431,7 @@ int cert_stuff(struct connectdata *conn,
 #ifdef HAVE_OPENSSL_ENGINE_H
       {                         /* XXXX still needs some work */
         EVP_PKEY *priv_key = NULL;
-        if(conn && conn->data && conn->data->state.engine) {
+        if(data->state.engine) {
 #ifdef HAVE_ENGINE_LOAD_FOUR_ARGS
           UI_METHOD *ui_method = UI_OpenSSL();
 #endif
@@ -441,7 +441,7 @@ int cert_stuff(struct connectdata *conn,
           }
           /* the typecast below was added to please mingw32 */
           priv_key = (EVP_PKEY *)
-            ENGINE_load_private_key(conn->data->state.engine,key_file,
+            ENGINE_load_private_key(data->state.engine,key_file,
 #ifdef HAVE_ENGINE_LOAD_FOUR_ARGS
                                     ui_method,
 #endif