]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ide: Use of_node_name_eq for node name comparisons
authorRob Herring <robh@kernel.org>
Wed, 5 Dec 2018 19:50:25 +0000 (13:50 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Sat, 22 Dec 2018 10:29:50 +0000 (21:29 +1100)
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-ide@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/ide/pmac.c

index c5b902b86b444773519edc1a52fe4d8782992f37..ec46aa84d18d23d43146bba1f29b0ef5f837d2da 100644 (file)
@@ -1045,7 +1045,7 @@ static int pmac_ide_setup_device(pmac_ide_hwif_t *pmif, struct ide_hw *hw)
                d.port_ops = &pmac_ide_ata4_port_ops;
                d.udma_mask = ATA_UDMA5;
        } else if (of_device_is_compatible(np, "keylargo-ata")) {
-               if (strcmp(np->name, "ata-4") == 0) {
+               if (of_node_name_eq(np, "ata-4")) {
                        pmif->kind = controller_kl_ata4;
                        d.port_ops = &pmac_ide_ata4_port_ops;
                        d.udma_mask = ATA_UDMA4;