]> git.ipfire.org Git - thirdparty/automake.git/commitdiff
bug#40699: "dist Hook" documentation in manual is incorrect or unclear about write...
authorVincent Lefevre <vincent@vinc17.net>
Thu, 23 Apr 2020 15:40:39 +0000 (17:40 +0200)
committerKarl Berry <karl@freefriends.org>
Fri, 24 Apr 2020 00:53:58 +0000 (17:53 -0700)
On 2020-04-20 14:59:00 -0600, Karl Berry wrote:
>     i.e. it does not change the permissions in order to make the removal
>     work recursively
>
> Right, I see it now. Had been testing the wrong thing.
>
> So, can you propose a specific change for the manual? -k

I think that it is sufficient to fix the example (the explanation
is just below). BTW, the second example is also incorrect.

commit a639e5b51cadbaff88ca4059b4db4571c811070c
Author: Vincent Lefevre <vincent@vinc17.net>
Date:   2020-04-23 17:33:54 +0200

    doc: fix dist-hook examples

doc/automake.texi

index 469a729718d6530a710a8783b5ed6b253341eb90..1b35883b9adbe89b63a254c93b957fb3c4a5ea6e 100644 (file)
@@ -8497,6 +8497,7 @@ a directory in @code{EXTRA_DIST}:
 @example
 EXTRA_DIST = doc
 dist-hook:
+        chmod -R u+w $(distdir)/doc
         rm -rf `find $(distdir)/doc -type d -name .svn`
 @end example
 
@@ -8516,7 +8517,7 @@ distribution directory, it should explicitly to make it writable first:
 EXTRA_DIST = README doc
 dist-hook:
         chmod u+w $(distdir)/README $(distdir)/doc
-        echo "Distribution date: `date`" >> README
+        echo "Distribution date: `date`" >> $(distdir)/README
         rm -f $(distdir)/doc/HACKING
 @end example