]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: v4l2-ctrls: set AV1 sequence flags for testing
authorPavan Bobba <opensource206@gmail.com>
Tue, 28 Oct 2025 06:26:23 +0000 (11:56 +0530)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 28 Oct 2025 10:06:11 +0000 (11:06 +0100)
Initialize additional AV1 sequence parameters in std_init_compound()
to make the default AV1 sequence control compatible with compliance
and userspace testing tools.

Specifically, set:
 - enable both SUBSAMPLING_X and SUBSAMPLING_Y flags

These defaults help ensure that V4L2_CID_AV1_SEQUENCE behaves
consistently during validation and v4l2-compliance tests.

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
[hverkuil: align everything a bit better]
[hverkuil: replaced Pavan's comment with comment suggested by Nicolas]
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/v4l2-core/v4l2-ctrls-core.c

index 7c660cd61e484f0813e5a9991845127b581c3b66..209bc05883bb15bc8614970e7b42595aad6dd18f 100644 (file)
@@ -160,7 +160,13 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
                break;
        case V4L2_CTRL_TYPE_AV1_SEQUENCE:
                p_av1_sequence = p;
+               /*
+                * The initial profile is 0 which only allows YUV 420 subsampled
+                * data. Set the subsampling flags accordingly.
+                */
                p_av1_sequence->bit_depth = 8;
+               p_av1_sequence->flags |= V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X |
+                                        V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y;
                break;
        case V4L2_CTRL_TYPE_FWHT_PARAMS:
                p_fwht_params = p;