]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rust: document `bindgen` 0.71.0 regression
authorMiguel Ojeda <ojeda@kernel.org>
Mon, 9 Dec 2024 21:25:44 +0000 (22:25 +0100)
committerMiguel Ojeda <ojeda@kernel.org>
Thu, 9 Jan 2025 23:17:00 +0000 (00:17 +0100)
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It
has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: https://github.com/rust-lang/rust-bindgen/issues/3039
Link: https://github.com/rust-lang/rust-bindgen/issues/2677
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09
Reviewed-by: Fiona Behrens <me@kloenk.dev>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20241209212544.1977065-1-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
init/Kconfig
scripts/rust_is_available.sh

index a20e6efd3f0fbdd7f0df2448854cc30734a0ee4f..e8d2b5128f8733b0ca40dfb8dfcef4b59e5be950 100644 (file)
@@ -1989,8 +1989,10 @@ config BINDGEN_VERSION_TEXT
        string
        depends on RUST
        # The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-       # (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-       # the minimum version is upgraded past that (0.69.1 already fixed the issue).
+       # (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+       # (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed
+       # when the minimum version is upgraded past the latter (0.69.1 and 0.71.1
+       # both fixed the issue).
        default "$(shell,$(BINDGEN) --version workaround-for-0.69.0 2>/dev/null)"
 
 #
index 93c0ef7fb3fb227c2176c0226da747825b8ae1eb..d2323de0692c17c9836c71eef31d85c530630e0f 100755 (executable)
@@ -123,8 +123,10 @@ fi
 # Non-stable and distributions' versions may have a version suffix, e.g. `-dev`.
 #
 # The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
-# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
-# the minimum version is upgraded past that (0.69.1 already fixed the issue).
+# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
+# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed when
+# the minimum version is upgraded past the latter (0.69.1 and 0.71.1 both fixed
+# the issue).
 rust_bindings_generator_output=$( \
        LC_ALL=C "$BINDGEN" --version workaround-for-0.69.0 2>/dev/null
 ) || rust_bindings_generator_code=$?