]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kunit: executor: Remove const from kunit_filter_suites() allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:24:34 +0000 (23:24 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 29 Apr 2025 18:48:27 +0000 (12:48 -0600)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct kunit_suite **" but the returned type will
be "struct kunit_suite * const *". Since it isn't generally possible
to remove the const qualifier, adjust the allocation type to match
the assignment.

Link: https://lore.kernel.org/r/20250426062433.work.124-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/executor.c

index 3f39955cb0f14be40b9028febfa0d16b62a3f3b6..0061d4c7e35170634a3c1d1cff7179037fb8ba07 100644 (file)
@@ -177,7 +177,7 @@ kunit_filter_suites(const struct kunit_suite_set *suite_set,
 
        const size_t max = suite_set->end - suite_set->start;
 
-       copy = kcalloc(max, sizeof(*filtered.start), GFP_KERNEL);
+       copy = kcalloc(max, sizeof(*copy), GFP_KERNEL);
        if (!copy) { /* won't be able to run anything, return an empty set */
                return filtered;
        }