]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx274: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:49 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./i2c/imx274.c:2038:32-39: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx274.c

index d86d08c29174584b26e109a7858542313219c19a..8ec78b60bea6d47d2088b8251b679224e0d34980 100644 (file)
@@ -2034,8 +2034,7 @@ static int imx274_probe(struct i2c_client *client)
        /* initialize regmap */
        imx274->regmap = devm_regmap_init_i2c(client, &imx274_regmap_config);
        if (IS_ERR(imx274->regmap)) {
-               dev_err(dev,
-                       "regmap init failed: %ld\n", PTR_ERR(imx274->regmap));
+               dev_err(dev, "regmap init failed: %pe\n", imx274->regmap);
                ret = -ENODEV;
                goto err_regmap;
        }