]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Ensure failure to talk to Xen hypervisor is fatal when privileged
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 20 Jul 2012 13:52:44 +0000 (14:52 +0100)
committerCole Robinson <crobinso@redhat.com>
Sun, 12 Aug 2012 23:23:51 +0000 (19:23 -0400)
As per the comment, the Xen hypervisor driver is considered to
be mandatory when running privileged. When it fails to open,
we should thus return an error, not ignore it.
(cherry picked from commit 489900e3de9de74ce4197807935ffc3ef8a68bca)

src/xen/xen_driver.c

index 9ff3d292d771385788e294220e838c41c88d8ef1..43b262061e78dc1a131dbdba2d375f6ac69094f0 100644 (file)
@@ -340,6 +340,8 @@ xenUnifiedOpen (virConnectPtr conn, virConnectAuthPtr auth, unsigned int flags)
         if (xenHypervisorOpen(conn, auth, flags) == VIR_DRV_OPEN_SUCCESS) {
             VIR_DEBUG("Activated hypervisor sub-driver");
             priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] = 1;
+        } else {
+            goto fail;
         }
     }