depmod: prevent module dependency files missing during depmod invocation

depmod deletes the module dependency files before moving the temporary
files in their place. This results in user seeing no dependency files
while they are updated. Remove the unlink call. The rename call should
suffice to move the new file in place and unlink the old one. It should
also do both atomically so there is no window when no dependency file
exists.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>

diff --git a/tools/depmod.c b/tools/depmod.c
index 989d9077926c195bee090290c050e874adc6b798..18c0d61b2db3f5bee881c34a92f8cc170c608ae3 100644 (file)
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2451,7 +2451,6 @@ static int depmod_output(struct depmod *depmod, FILE *out)
                        break;
                }
 
-               unlinkat(dfd, itr->name, 0);
                if (renameat(dfd, tmp, dfd, itr->name) != 0) {
                        err = -errno;
                        CRIT("renameat(%s, %s, %s, %s): %m\n",