block: fix NULL pointer dereference in blk_zone_reset_all_bio_endio()

For zoned block devices that do not need zone write plugs (e.g. most
device mapper devices that support zones), the disk hash table of zone
write plugs is NULL. For such devices, blk_zone_reset_all_bio_endio()
should not attempt to scan this has table as that causes a NULL pointer
dereference.

Fix this by checking that the disk does have zone write plugs using the
atomic counter. This is equivalent to checking for a non-NULL hash table
but has the advantage to also speed up the execution of
blk_zone_reset_all_bio_endio() for devices that do use zone write plugs
but do not have any plug in the hash table (e.g. a disk with only full
zones).

Fixes: efae226c2ef1 ("block: handle zone management operations completions")
Reported-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 85de45c3f6be1605059b1f884cdd1a081830a52c..98c26af01e24062e6b99ab765073733de1760b4b 100644 (file)
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -1118,17 +1118,20 @@ static void blk_zone_reset_all_bio_endio(struct bio *bio)
        sector_t sector;
        unsigned int i;
 
-       /* Update the condition of all zone write plugs. */
-       rcu_read_lock();
-       for (i = 0; i < disk_zone_wplugs_hash_size(disk); i++) {
-               hlist_for_each_entry_rcu(zwplug, &disk->zone_wplugs_hash[i],
-                                        node) {
-                       spin_lock_irqsave(&zwplug->lock, flags);
-                       disk_zone_wplug_set_wp_offset(disk, zwplug, 0);
-                       spin_unlock_irqrestore(&zwplug->lock, flags);
+       if (atomic_read(&disk->nr_zone_wplugs)) {
+               /* Update the condition of all zone write plugs. */
+               rcu_read_lock();
+               for (i = 0; i < disk_zone_wplugs_hash_size(disk); i++) {
+                       hlist_for_each_entry_rcu(zwplug,
+                                                &disk->zone_wplugs_hash[i],
+                                                node) {
+                               spin_lock_irqsave(&zwplug->lock, flags);
+                               disk_zone_wplug_set_wp_offset(disk, zwplug, 0);
+                               spin_unlock_irqrestore(&zwplug->lock, flags);
+                       }
                }
+               rcu_read_unlock();
        }
-       rcu_read_unlock();
 
        /* Update the cached zone conditions. */
        for (sector = 0; sector < capacity;