]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HID: core: do not bypass hid_hw_raw_request
authorBenjamin Tissoires <bentiss@kernel.org>
Thu, 10 Jul 2025 14:01:35 +0000 (16:01 +0200)
committerBenjamin Tissoires <bentiss@kernel.org>
Sun, 13 Jul 2025 07:53:27 +0000 (09:53 +0200)
hid_hw_raw_request() is actually useful to ensure the provided buffer
and length are valid. Directly calling in the low level transport driver
function bypassed those checks and allowed invalid paramto be used.

Reported-by: Alan Stern <stern@rowland.harvard.edu>
Closes: https://lore.kernel.org/linux-input/c75433e0-9b47-4072-bbe8-b1d14ea97b13@rowland.harvard.edu/
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250710-report-size-null-v2-3-ccf922b7c4e5@kernel.org
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-core.c

index 320887c365f7a36f7376556ffd19f99e52b7d732..b31b8a2fd540bd5ed66599020824726e69d10d75 100644 (file)
@@ -1996,8 +1996,7 @@ int __hid_request(struct hid_device *hid, struct hid_report *report,
        if (reqtype == HID_REQ_SET_REPORT)
                hid_output_report(report, data_buf);
 
-       ret = hid->ll_driver->raw_request(hid, report->id, buf, len,
-                                         report->type, reqtype);
+       ret = hid_hw_raw_request(hid, report->id, buf, len, report->type, reqtype);
        if (ret < 0) {
                dbg_hid("unable to complete request: %d\n", ret);
                goto out;