To: git@vger.kernel.org
-Subject: What's cooking in git.git (Aug 2024, #06; Fri, 16)
-X-master-at: 87a1768b93a67d0420255a43d9e07387b2e805ad
-X-next-at: a157f53b32d1635eb6dc54bf001924b543cd6568
+Subject: What's cooking in git.git (Aug 2024, #07; Mon, 19)
+X-master-at: bb9c16bd4f1a9a00799e10c81ee6506cf468c0c7
+X-next-at: 58194ef3dc4e17ce4fbb862d7d4cc852f9f686ad
Bcc: lwn@lwn.net, gitster@pobox.com
-What's cooking in git.git (Aug 2024, #06; Fri, 16)
+What's cooking in git.git (Aug 2024, #07; Mon, 19)
--------------------------------------------------
Here are the topics that have been cooking in my tree. Commits
no activity (of course they can be resubmit when new interests
arise).
+A handful of "safe" topics that have been in 'master' are merged on
+top of v2.46.0 on the 'maint' branch, which may become part of Git
+2.46.1 if we decide that we need such an maintenance update. The
+fixes currently there are small enough that the do not warrant an
+immediate release of such a maintenance update, though.
+
+Among the topics that were sent to the list but not in 'next', there
+are a few (conceptual) biggies like the Rust binding, clar unit test
+framework, and documentation mark-up with s:[], that may need
+further discussion. There also are topics that are not covered well
+by reviewers (yet).
+
Copies of the source code to Git live in many repositories, and the
following is a list of the ones I push into or their mirrors. Some
repositories have only a subset of branches.
https://www.kernel.org/pub/software/scm/git/
--------------------------------------------------
-[Graduated to 'master']
+[New Topics]
-* ag/t7004-modernize (2024-08-08) 8 commits
- (merged to 'next' on 2024-08-09 at 7bce577df4)
- + t7004: make use of write_script
- + t7004: use single quotes instead of double quotes
- + t7004: begin the test body on the same line as test_expect_success
- + t7004: description on the same line as test_expect_success
- + t7004: do not prepare things outside test_expect_success
- + t7004: use indented here-doc
- + t7004: one command per line
- + t7004: remove space after redirect operators
+* jk/mark-unused-parameters (2024-08-17) 15 commits
+ (merged to 'next' on 2024-08-19 at f85d6096c9)
+ + scalar: mark unused parameters in dummy function
+ + daemon: mark unused parameters in non-posix fallbacks
+ + setup: mark unused parameter in config callback
+ + test-mergesort: mark unused parameters in trivial callback
+ + t-hashmap: mark unused parameters in callback function
+ + reftable: mark unused parameters in virtual functions
+ + reftable: drop obsolete test function declarations
+ + reftable: ignore unused argc/argv in test functions
+ + unit-tests: ignore unused argc/argv
+ + t/helper: mark more unused argv/argc arguments
+ + oss-fuzz: mark unused argv/argc argument
+ + refs: mark unused parameters in do_for_each_reflog_helper()
+ + refs: mark unused parameters in ref_store fsck callbacks
+ + update-ref: mark more unused parameters in parser callbacks
+ + imap-send: mark unused parameter in ssl_socket_connect() fallback
+
+ Mark unused parameters as UNUSED to squelch -Wunused warnings.
+
+ Will merge to 'master'.
+ source: <20240817082101.GA6761@coredump.intra.peff.net>
- Coding style fixes to a test script.
- source: <20240808163302.17521-1-abdobngad@gmail.com>
+* jk/drop-unused-parameters (2024-08-17) 5 commits
+ (merged to 'next' on 2024-08-19 at f5c703013d)
+ + diff-lib: drop unused index argument from get_stat_data()
+ + ref-filter: drop unused parameters from email_atom_option_parser()
+ + pack-bitmap: drop unused parameters from select_pseudo_merges()
+ + pack-bitmap: load writer config from repository parameter
+ + refs: drop some unused parameters from create_symref_lock()
-* es/doc-platform-support-policy (2024-08-02) 1 commit
- (merged to 'next' on 2024-08-09 at 110c94ea82)
- + Documentation: add platform support policy
+ Drop unused parameters from functions.
- A policy document that describes platform support levels and
- expectation on platform stakeholders has been introduced.
- source: <20240802221948.2367124-1-emilyshaffer@google.com>
+ Will merge to 'master'.
+ source: <20240817072621.GA1535666@coredump.intra.peff.net>
-* gt/unit-test-hashmap (2024-08-06) 1 commit
- (merged to 'next' on 2024-08-09 at e62febfb4e)
- + t: port helper/test-hashmap.c to unit-tests/t-hashmap.c
+* ps/maintenance-detach-fix-more (2024-08-19) 3 commits
+ - builtin/maintenance: fix loose objects task emitting pack hash
+ - t7900: exercise detaching via trace2 regions
+ - t7900: fix flaky test due to leaking background job
+ (this branch uses ps/maintenance-detach-fix.)
- An existing test of hashmap API has been rewritten with the
- unit-test framework.
- cf. <CAP8UFD04uQbWhY0QDp+nC8VyBvpUs=tBDm=w4CzKK2GcwFZdGQ@mail.gmail.com>
- source: <20240803133517.73308-2-shyamthakkar001@gmail.com>
+ A tests for "git maintenance" that were broken on Windows have been
+ corrected.
+ Expecting a (hopefully small and final) reroll.
+ cf. <ZsMIxmX2Ash9YtEU@tanuki>
+ source: <cover.1724053639.git.ps@pks.im>
-* jc/refs-symref-referent (2024-08-09) 3 commits
- (merged to 'next' on 2024-08-09 at 3183f3d05b)
- + ref-filter: populate symref from iterator
- + refs: add referent to each_ref_fn
- + refs: keep track of unresolved reference value in iterators
- The refs API has been taught to give symref target information to
- the users of ref iterators, allowing for-each-ref and friends to
- avoid an extra ref_resolve_* API call per a symbolic ref.
- source: <pull.1712.v4.git.git.1723217871.gitgitgadget@gmail.com>
+* ps/reftable-concurrent-compaction (2024-08-19) 10 commits
+ - reftable/stack: fix segfault when reload with reused readers fails
+ - reftable/stack: reorder swapping in the reloaded stack contents
+ - reftable/reader: keep readers alive during iteration
+ - reftable/reader: introduce refcounting
+ - reftable/stack: fix broken refnames in `write_n_ref_tables()`
+ - reftable/reader: inline `reader_close()`
+ - reftable/reader: inline `init_reader()`
+ - reftable/reader: rename `reftable_new_reader()`
+ - reftable/stack: inline `stack_compact_range_stats()`
+ - reftable/blocksource: drop malloc block source
+ (this branch uses ps/reftable-drop-generic.)
+ source: <cover.1723640107.git.ps@pks.im>
+ source: <cover.1724080006.git.ps@pks.im>
+
+--------------------------------------------------
+[Graduated to 'master']
+
+* jc/tests-no-useless-tee (2024-08-08) 1 commit
+ (merged to 'next' on 2024-08-12 at 188e777e16)
+ + tests: drop use of 'tee' that hides exit status
-* jc/safe-directory (2024-07-30) 4 commits
- (merged to 'next' on 2024-08-05 at 77aa0f1d08)
- + safe.directory: setting safe.directory="." allows the "current" directory
- + safe.directory: normalize the configured path
- + safe.directory: normalize the checked path
- + safe.directory: preliminary clean-up
+ Test fixes.
+ source: <xmqq4j7uhfvm.fsf@gitster.g>
- Follow-up on 2.45.1 regression fix.
- source: <20240730184352.2503276-1-gitster@pobox.com>
+* ps/transport-leakfix-test-updates (2024-08-08) 1 commit
+ (merged to 'next' on 2024-08-12 at ee80dbc4f6)
+ + transport: mark more tests leak-free
-* jc/t3206-test-when-finished-fix (2024-08-06) 1 commit
- (merged to 'next' on 2024-08-08 at 46461db3a2)
- + t3206: test_when_finished before dirtying operations, not after
+ Test updates.
+ source: <ZrRV_HrUArsvRgn8@tanuki>
- Test clean-up.
- source: <xmqqwmkttwfm.fsf@gitster.g>
+* rs/unit-tests-test-run (2024-07-30) 6 commits
+ (merged to 'next' on 2024-08-12 at 9df4336877)
+ + t-strvec: use if_test
+ + t-reftable-basics: use if_test
+ + t-ctype: use if_test
+ + unit-tests: add if_test
+ + unit-tests: show location of checks outside of tests
+ + t0080: use here-doc test body
-* ps/reftable-stack-compaction (2024-08-08) 9 commits
- (merged to 'next' on 2024-08-09 at d7875bf14b)
- + reftable/stack: handle locked tables during auto-compaction
- + reftable/stack: fix corruption on concurrent compaction
- + reftable/stack: use lock_file when adding table to "tables.list"
- + reftable/stack: do not die when fsyncing lock file files
- + reftable/stack: simplify tracking of table locks
- + reftable/stack: update stats on failed full compaction
- + reftable/stack: test compaction with already-locked tables
- + reftable/stack: extract function to setup stack with N tables
- + reftable/stack: refactor function to gather table sizes
- (this branch is used by ps/reftable-drop-generic.)
+ Unit-test framework has learned a simple control structure to allow
+ embedding test statements in-line instead of having to create a new
+ function to contain them.
+ source: <077a178e-eb30-45ff-b653-a514bfd33077@web.de>
- The code paths to compact multiple reftable files have been updated
- to correctly deal with multiple compaction triggering at the same
- time.
- source: <cover.1723123606.git.ps@pks.im>
+* sj/ref-fsck (2024-08-08) 9 commits
+ (merged to 'next' on 2024-08-09 at 3bde10da94)
+ + fsck: add ref name check for files backend
+ + files-backend: add unified interface for refs scanning
+ + builtin/refs: add verify subcommand
+ + refs: set up ref consistency check infrastructure
+ + fsck: add refs report function
+ + fsck: add a unified interface for reporting fsck messages
+ + fsck: make "fsck_error" callback generic
+ + fsck: rename objects-related fsck error functions
+ + fsck: rename "skiplist" to "skip_oids"
-* ps/submodule-ref-format (2024-08-08) 8 commits
- (merged to 'next' on 2024-08-09 at 2b17964809)
- + object: fix leaking packfiles when closing object store
- + submodule: fix leaking seen submodule names
- + submodule: fix leaking fetch tasks
- + builtin/submodule: allow "add" to use different ref storage format
- + refs: fix ref storage format for submodule ref stores
- + builtin/clone: propagate ref storage format to submodules
- + builtin/submodule: allow cloning with different ref storage format
- + git-submodule.sh: break overly long command lines
+ "git fsck" infrastructure has been taught to also check the sanity
+ of the ref database, in addition to the object database.
+ source: <ZrSqMmD-quQ18a9F@ArchLinux.localdomain>
- Support to specify ref backend for submodules has been enhanced.
- source: <cover.1723102259.git.ps@pks.im>
+* tb/incremental-midx-part-1 (2024-08-06) 19 commits
+ (merged to 'next' on 2024-08-12 at 92ec55fd49)
+ + midx: implement support for writing incremental MIDX chains
+ + t/t5313-pack-bounds-checks.sh: prepare for sub-directories
+ + t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
+ + midx: implement verification support for incremental MIDXs
+ + midx: support reading incremental MIDX chains
+ + midx: teach `midx_fanout_add_midx_fanout()` about incremental MIDXs
+ + midx: teach `midx_preferred_pack()` about incremental MIDXs
+ + midx: teach `midx_contains_pack()` about incremental MIDXs
+ + midx: remove unused `midx_locate_pack()`
+ + midx: teach `fill_midx_entry()` about incremental MIDXs
+ + midx: teach `nth_midxed_offset()` about incremental MIDXs
+ + midx: teach `bsearch_midx()` about incremental MIDXs
+ + midx: introduce `bsearch_one_midx()`
+ + midx: teach `nth_bitmapped_pack()` about incremental MIDXs
+ + midx: teach `nth_midxed_object_oid()` about incremental MIDXs
+ + midx: teach `prepare_midx_pack()` about incremental MIDXs
+ + midx: teach `nth_midxed_pack_int_id()` about incremental MIDXs
+ + midx: add new fields for incremental MIDX chains
+ + Documentation: describe incremental MIDX format
+ (this branch is used by jk/midx-unused-fix and tb/incremental-midx-part-2.)
-* rs/t-example-simplify (2024-07-30) 1 commit
- (merged to 'next' on 2024-08-08 at edeb01c38e)
- + t-example-decorate: remove test messages
+ Incremental updates of multi-pack index files.
+ source: <cover.1722958595.git.me@ttaylorr.com>
- Unit test simplification.
- source: <5c838884-b606-465a-8f7e-ab760ddadef8@web.de>
+--------------------------------------------------
+[Stalled]
+* pp/add-parse-range-unit-test (2024-05-27) 1 commit
+ - apply: add unit tests for parse_range
-* xx/diff-tree-remerge-diff-fix (2024-08-09) 1 commit
- (merged to 'next' on 2024-08-09 at cabe67c0d1)
- + diff-tree: fix crash when used with --remerge-diff
- (this branch is used by jc/range-diff-lazy-setup.)
+ A unit test for code that parses the hunk offset and length from a
+ patch fragment header as been added.
- "git rev-list ... | git diff-tree -p --remerge-diff --stdin" should
- behave more or less like "git log -p --remerge-diff" but instead it
- crashed, forgetting to prepare a temporary object store needed.
- source: <pull.1771.v2.git.1723188292498.gitgitgadget@gmail.com>
+ Expecting a reroll.
+ cf. <b7eca313-9ea8-4132-ba1d-ed9236e07095@gmail.com>
+ source: <pull.1677.v2.git.git.1716710073910.gitgitgadget@gmail.com>
--------------------------------------------------
-[New Topics]
+[Cooking]
* jc/how-to-maintain-updates (2024-08-14) 1 commit
(merged to 'next' on 2024-08-15 at 20ebc08e74)
source: <xmqqikw2wvup.fsf@gitster.g>
-* ah/git-prompt-portability (2024-08-15) 8 commits
+* ah/git-prompt-portability (2024-08-17) 8 commits
- git-prompt: support custom 0-width PS1 markers
- git-prompt: ta-da! document usage in other shells
- git-prompt: don't use shell $'...'
which has been corrected to work with more shells.
Will merge to 'next'?
- source: <pull.1750.v2.git.git.1723727653.gitgitgadget@gmail.com>
+ source: <pull.1750.v3.git.git.1723886760.gitgitgadget@gmail.com>
* jk/apply-patch-mode-check-fix (2024-08-15) 1 commit
- reftable/merged: rename `reftable_new_merged_table()`
- reftable/merged: expose functions to initialize iterators
- Merge branch 'ps/reftable-stack-compaction' into ps/reftable-drop-generic
+ (this branch is used by ps/reftable-concurrent-compaction.)
The code in the reftable library has been cleaned up by discarding
unused "generic" interface.
* ps/hash-and-ref-format-from-config (2024-08-16) 5 commits
- - setup: make ref storage format configurable via config
- - setup: make object format configurable via config
- - setup: merge configuration of repository formats
- - t0001: delete repositories when object format tests finish
- - t0001: exercise initialization with ref formats more thoroughly
+ (merged to 'next' on 2024-08-16 at 2028c02d01)
+ + setup: make ref storage format configurable via config
+ + setup: make object format configurable via config
+ + setup: merge configuration of repository formats
+ + t0001: delete repositories when object format tests finish
+ + t0001: exercise initialization with ref formats more thoroughly
The default object hash and ref backend format used to be settable
only with explicit command line option to "git init" and
environment variables, but now they can be configured in the user's
global and system wide configuration.
- Will merge to 'next'.
+ Will merge to 'master'.
source: <cover.1723798388.git.ps@pks.im>
* tb/pseudo-merge-bitmap-fixes (2024-08-15) 8 commits
- - pseudo-merge.c: ensure pseudo-merge groups are closed
- - pseudo-merge.c: do not generate empty pseudo-merge commits
- - t/t5333-pseudo-merge-bitmaps.sh: demonstrate empty pseudo-merge groups
- - pack-bitmap-write.c: select pseudo-merges even for small bitmaps
- - pack-bitmap: drop redundant args from `bitmap_writer_finish()`
- - pack-bitmap: drop redundant args from `bitmap_writer_build()`
- - pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()`
- - pack-bitmap: initialize `bitmap_writer_init()` with packing_data
+ (merged to 'next' on 2024-08-19 at 10cc82b2fb)
+ + pseudo-merge.c: ensure pseudo-merge groups are closed
+ + pseudo-merge.c: do not generate empty pseudo-merge commits
+ + t/t5333-pseudo-merge-bitmaps.sh: demonstrate empty pseudo-merge groups
+ + pack-bitmap-write.c: select pseudo-merges even for small bitmaps
+ + pack-bitmap: drop redundant args from `bitmap_writer_finish()`
+ + pack-bitmap: drop redundant args from `bitmap_writer_build()`
+ + pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()`
+ + pack-bitmap: initialize `bitmap_writer_init()` with packing_data
(this branch is used by tb/incremental-midx-part-2.)
We created a useless pseudo-merge reachability bitmap that is about
0 commits, and attempted to include commits that are not in packs,
which made no sense. These bugs have been corrected.
- Will merge to 'next'.
+ Will merge to 'master'.
+ cf. <20240817104412.GE551779@coredump.intra.peff.net>
source: <cover.1723743050.git.me@ttaylorr.com>
- Documentation: describe incremental MIDX bitmaps
- Merge branch 'tb/pseudo-merge-bitmap-fixes' into tb/incremental-midx-part-2
- Merge branch 'tb/incremental-midx-part-1' into tb/incremental-midx-part-2
- (this branch uses tb/incremental-midx-part-1 and tb/pseudo-merge-bitmap-fixes.)
+ (this branch uses tb/pseudo-merge-bitmap-fixes.)
Incremental updates of multi-pack index files.
+ Needs review.
source: <cover.1723760847.git.me@ttaylorr.com>
-* mt/rebase-x-quiet (2024-08-15) 1 commit
+* mt/rebase-x-quiet (2024-08-16) 1 commit
- rebase -x: don't print "Executing:" msgs with --quiet
"git rebase -x --quiet" was not quiet, which was corrected.
Expecting a reroll.
- cf. <Zr8NOh-gMuhp-p0M@tanuki>
- source: <767ea219e3365303535c8b5f0d8eadb28b5e872e.1723778779.git.matheus.tavb@gmail.com>
+ source: <be3c968b0d9085843cd9ce67e85aadfaaafa69c8.1723848510.git.matheus.tavb@gmail.com>
-* ps/stash-keep-unrack-empty-fix (2024-08-16) 1 commit
- - builtin/stash: fix `--keep-index --include-untracked` with empty HEAD
+* ps/stash-keep-untrack-empty-fix (2024-08-16) 1 commit
+ (merged to 'next' on 2024-08-16 at 3db6b6a815)
+ + builtin/stash: fix `--keep-index --include-untracked` with empty HEAD
A corner case bug in "git stash" was fixed.
- Will merge to 'next'.
+ Will merge to 'master'.
source: <6067675b5edf36e2eb28e98119a1c02d0a7ae670.1723804926.git.ps@pks.im>
---------------------------------------------------
-[Stalled]
-
-* pp/add-parse-range-unit-test (2024-05-27) 1 commit
- - apply: add unit tests for parse_range
-
- A unit test for code that parses the hunk offset and length from a
- patch fragment header as been added.
-
- Expecting a reroll.
- cf. <b7eca313-9ea8-4132-ba1d-ed9236e07095@gmail.com>
- source: <pull.1677.v2.git.git.1716710073910.gitgitgadget@gmail.com>
-
---------------------------------------------------
-[Cooking]
* gt/unit-test-urlmatch-normalization (2024-08-14) 1 commit
- t: migrate t0110-urlmatch-normalization to the new framework
Another rewrite of test.
- Comments?
+ Expecting a (hopefully small and final) reroll.
+ cf. <CAP8UFD2-VbyK-ZecDKEvgKicWrVe=e=z6mH_xjmrf=a4ZAYd8w@mail.gmail.com>
source: <20240814142057.94671-1-shyamthakkar001@gmail.com>
* jk/midx-unused-fix (2024-08-13) 1 commit
(merged to 'next' on 2024-08-14 at 2ec51e52e1)
+ midx: drop unused parameters from add_midx_to_chain()
- (this branch uses tb/incremental-midx-part-1.)
Code clean-up in the base topic.
Will merge to 'master'.
- source: <cover.1722958595.git.me@ttaylorr.com>
+ source: <20240813050216.GA394231@coredump.intra.peff.net>
* ps/bundle-outside-repo-fix (2024-08-13) 2 commits
* ps/clar-unit-test (2024-08-16) 9 commits
- - t/unit-tests: convert ctype tests to use clar
- - t/unit-tests: convert strvec tests to use clar
- - Makefile: wire up the clar unit testing framework
- - Makefile: do not use sparse on third-party sources
- - Makefile: make hdr-check depend on generated headers
- - Makefile: fix sparse dependency on GENERATED_H
- - t/clar: fix compatibility with NonStop
- - t: import the clar unit testing framework
- - t: do not pass GIT_TEST_OPTS to unit tests with prove
+ . t/unit-tests: convert ctype tests to use clar
+ . t/unit-tests: convert strvec tests to use clar
+ . Makefile: wire up the clar unit testing framework
+ . Makefile: do not use sparse on third-party sources
+ . Makefile: make hdr-check depend on generated headers
+ . Makefile: fix sparse dependency on GENERATED_H
+ . t/clar: fix compatibility with NonStop
+ . t: import the clar unit testing framework
+ . t: do not pass GIT_TEST_OPTS to unit tests with prove
Import clar unit tests framework libgit2 folks invented for our
use.
- Needs to decide how to fill feature gap with our home-grown one
+ Need to decide how to fill feature gap with our home-grown one
cf. <b87700d2-0c9a-4d0c-9ee4-e6a91278d596@gmail.com>
+ Fails to build on Windows.
+ cf. https://github.com/git/git/actions/runs/10424256896/job/28875787680
source: <cover.1723791831.git.ps@pks.im>
* ps/maintenance-detach-fix (2024-08-16) 7 commits
- - run-command: fix detaching when running auto maintenance
- - builtin/maintenance: add a `--detach` flag
- - builtin/gc: add a `--detach` flag
- - builtin/gc: stop processing log file on signal
- - builtin/gc: fix leaking config values
- - builtin/gc: refactor to read config into structure
- - config: fix constness of out parameter for `git_config_get_expiry()`
+ (merged to 'next' on 2024-08-16 at 5db1344236)
+ + run-command: fix detaching when running auto maintenance
+ + builtin/maintenance: add a `--detach` flag
+ + builtin/gc: add a `--detach` flag
+ + builtin/gc: stop processing log file on signal
+ + builtin/gc: fix leaking config values
+ + builtin/gc: refactor to read config into structure
+ + config: fix constness of out parameter for `git_config_get_expiry()`
+ (this branch is used by ps/maintenance-detach-fix-more.)
Allow maintance tasks other than "gc" to properly go background
when "git maintenance" run them.
- Will merge to 'next'.
+ Will wait for the other topic and then merge to 'master'.
source: <cover.1723804990.git.ps@pks.im>
-* jk/send-email-translate-aliases (2024-08-15) 4 commits
- - fixup! send-email: teach git send-email option to translate aliases
- - send-email: teach git send-email option to translate aliases
- - t9001-send-email.sh: update alias list used for pine test
- - t9001-send-email.sh: fix quoting for mailrc --dump-aliases test
+* jk/send-email-translate-aliases (2024-08-17) 3 commits
+ (merged to 'next' on 2024-08-19 at dd207c3560)
+ + send-email: teach git send-email option to translate aliases
+ + t9001-send-email.sh: update alias list used for pine test
+ + t9001-send-email.sh: fix quoting for mailrc --dump-aliases test
"git send-email" learned "--translate-aliases" option that reads
addresses from the standard input and emits the result of applying
aliases on them to the standard output.
- Will merge to 'next' after squashing the fix in.
+ Will merge to 'master'.
source: <20240813-jk-translate-alias-send-email-v2-0-912db4eb6846@gmail.com>
-* cp/unit-test-reftable-block (2024-08-14) 10 commits
- - t-reftable-block: add tests for index blocks
- - t-reftable-block: add tests for obj blocks
- - t-reftable-block: add tests for log blocks
- - t-reftable-block: remove unnecessary variable 'j'
- - t-reftable-block: use xstrfmt() instead of xstrdup()
- - t-reftable-block: use block_iter_reset() instead of block_iter_close()
- - t-reftable-block: use reftable_record_key() instead of strbuf_addstr()
- - t-reftable-block: use reftable_record_equal() instead of check_str()
- - t-reftable-block: release used block reader
- - t: move reftable/block_test.c to the unit testing framework
+* cp/unit-test-reftable-block (2024-08-19) 11 commits
+ . t-reftable-block: add tests for index blocks
+ . t-reftable-block: add tests for obj blocks
+ . t-reftable-block: add tests for log blocks
+ . t-reftable-block: remove unnecessary variable 'j'
+ . t-reftable-block: use xstrfmt() instead of xstrdup()
+ . t-reftable-block: use block_iter_reset() instead of block_iter_close()
+ . t-reftable-block: use reftable_record_key() instead of strbuf_addstr()
+ . t-reftable-block: use reftable_record_equal() instead of check_str()
+ . t-reftable-block: release used block reader
+ . t: harmonize t-reftable-block.c with coding guidelines
+ . t: move reftable/block_test.c to the unit testing framework
Another test for reftable library ported to the unit test framework.
- Needs Review.
- source: <20240814121122.4642-1-chandrapratap3519@gmail.com>
-
-
-* jc/tests-no-useless-tee (2024-08-08) 1 commit
- (merged to 'next' on 2024-08-12 at 188e777e16)
- + tests: drop use of 'tee' that hides exit status
-
- Test fixes.
-
- Will merge to 'master'.
- source: <xmqq4j7uhfvm.fsf@gitster.g>
+ Expecting a reroll.
+ cf. <CA+J6zkQa9=7C_f=NqGHEEVhnAJZQ7q9gDMhFQ_F2QDn3RDJ+cA@mail.gmail.com>
+ source: <20240816175414.5169-1-chandrapratap3519@gmail.com>
* js/libgit-rust (2024-08-09) 5 commits
An rust binding to libgit.a functions has been introduced.
- Inviting further comments.
+ Comments?
source: <cover.1723242556.git.steadmon@google.com>
* ps/leakfixes-part-4 (2024-08-14) 23 commits
- - builtin/diff: free symmetric diff members
- - diff: free state populated via options
- - builtin/log: fix leak when showing converted blob contents
- - userdiff: fix leaking memory for configured diff drivers
- - builtin/format-patch: fix various trivial memory leaks
- - diff: fix leak when parsing invalid ignore regex option
- - unpack-trees: clear index when not propagating it
- - sequencer: release todo list on error paths
- - merge-ort: unconditionally release attributes index
- - builtin/fast-export: plug leaking tag names
- - builtin/fast-export: fix leaking diff options
- - builtin/fast-import: plug trivial memory leaks
- - builtin/notes: fix leaking `struct notes_tree` when merging notes
- - builtin/rebase: fix leaking `commit.gpgsign` value
- - config: fix leaking comment character config
- - submodule-config: fix leaking name entry when traversing submodules
- - read-cache: fix leaking hashfile when writing index fails
- - bulk-checkin: fix leaking state TODO
- - object-name: fix leaking symlink paths in object context
- - object-file: fix memory leak when reading corrupted headers
- - git: fix leaking system paths
- - remote: plug memory leak when aliasing URLs
- - Merge branch 'ps/leakfixes-part-3' into ps/leakfixes-part-4
+ (merged to 'next' on 2024-08-16 at 37502271ec)
+ + builtin/diff: free symmetric diff members
+ + diff: free state populated via options
+ + builtin/log: fix leak when showing converted blob contents
+ + userdiff: fix leaking memory for configured diff drivers
+ + builtin/format-patch: fix various trivial memory leaks
+ + diff: fix leak when parsing invalid ignore regex option
+ + unpack-trees: clear index when not propagating it
+ + sequencer: release todo list on error paths
+ + merge-ort: unconditionally release attributes index
+ + builtin/fast-export: plug leaking tag names
+ + builtin/fast-export: fix leaking diff options
+ + builtin/fast-import: plug trivial memory leaks
+ + builtin/notes: fix leaking `struct notes_tree` when merging notes
+ + builtin/rebase: fix leaking `commit.gpgsign` value
+ + config: fix leaking comment character config
+ + submodule-config: fix leaking name entry when traversing submodules
+ + read-cache: fix leaking hashfile when writing index fails
+ + bulk-checkin: fix leaking state TODO
+ + object-name: fix leaking symlink paths in object context
+ + object-file: fix memory leak when reading corrupted headers
+ + git: fix leaking system paths
+ + remote: plug memory leak when aliasing URLs
+ + Merge branch 'ps/leakfixes-part-3' into ps/leakfixes-part-4
More leak fixes.
- Will merge to 'next'.
+ Will merge to 'master'.
source: <cover.1723614263.git.ps@pks.im>
* cp/unit-test-reftable-readwrite (2024-08-13) 4 commits
- - t-reftable-readwrite: add test for known error
- - t-reftable-readwrite: use 'for' in place of infinite 'while' loops
- - t-reftable-readwrite: use free_names() instead of a for loop
- - t: move reftable/readwrite_test.c to the unit testing framework
+ (merged to 'next' on 2024-08-16 at 8d68f73455)
+ + t-reftable-readwrite: add test for known error
+ + t-reftable-readwrite: use 'for' in place of infinite 'while' loops
+ + t-reftable-readwrite: use free_names() instead of a for loop
+ + t: move reftable/readwrite_test.c to the unit testing framework
- Will merge to 'next'.
+ Will merge to 'master'.
source: <20240813144440.4602-1-chandrapratap3519@gmail.com>
* ps/config-wo-the-repository (2024-08-13) 21 commits
- - config: hide functions using `the_repository` by default
- - global: prepare for hiding away repo-less config functions
- - config: don't depend on `the_repository` with branch conditions
- - config: don't have setters depend on `the_repository`
- - config: pass repo to functions that rename or copy sections
- - config: pass repo to `git_die_config()`
- - config: pass repo to `git_config_get_expiry_in_days()`
- - config: pass repo to `git_config_get_expiry()`
- - config: pass repo to `git_config_get_max_percent_split_change()`
- - config: pass repo to `git_config_get_split_index()`
- - config: pass repo to `git_config_get_index_threads()`
- - config: expose `repo_config_clear()`
- - config: introduce missing setters that take repo as parameter
- - path: hide functions using `the_repository` by default
- - path: stop relying on `the_repository` in `worktree_git_path()`
- - path: stop relying on `the_repository` when reporting garbage
- - hooks: remove implicit dependency on `the_repository`
- - editor: do not rely on `the_repository` for interactive edits
- - path: expose `do_git_common_path()` as `repo_common_pathv()`
- - path: expose `do_git_path()` as `repo_git_pathv()`
- - Merge branch 'ps/refs-wo-the-repository' into ps/config-wo-the-repository
+ (merged to 'next' on 2024-08-16 at 3d5462a90e)
+ + config: hide functions using `the_repository` by default
+ + global: prepare for hiding away repo-less config functions
+ + config: don't depend on `the_repository` with branch conditions
+ + config: don't have setters depend on `the_repository`
+ + config: pass repo to functions that rename or copy sections
+ + config: pass repo to `git_die_config()`
+ + config: pass repo to `git_config_get_expiry_in_days()`
+ + config: pass repo to `git_config_get_expiry()`
+ + config: pass repo to `git_config_get_max_percent_split_change()`
+ + config: pass repo to `git_config_get_split_index()`
+ + config: pass repo to `git_config_get_index_threads()`
+ + config: expose `repo_config_clear()`
+ + config: introduce missing setters that take repo as parameter
+ + path: hide functions using `the_repository` by default
+ + path: stop relying on `the_repository` in `worktree_git_path()`
+ + path: stop relying on `the_repository` when reporting garbage
+ + hooks: remove implicit dependency on `the_repository`
+ + editor: do not rely on `the_repository` for interactive edits
+ + path: expose `do_git_common_path()` as `repo_common_pathv()`
+ + path: expose `do_git_path()` as `repo_git_pathv()`
+ + Merge branch 'ps/refs-wo-the-repository' into ps/config-wo-the-repository
Use of API functions that implicitly depend on the_repository
object in the config subsystem has been rewritten to pass a
repository object through the callchain.
- Will merge to 'next'.
- source: <cover.1723540226.git.ps@pks.im>
-
-
-* ps/transport-leakfix-test-updates (2024-08-08) 1 commit
- (merged to 'next' on 2024-08-12 at ee80dbc4f6)
- + transport: mark more tests leak-free
-
- Test updates.
-
Will merge to 'master'.
- source: <ZrRV_HrUArsvRgn8@tanuki>
+ source: <cover.1723540226.git.ps@pks.im>
* ds/for-each-ref-is-base (2024-08-14) 4 commits
that the history leading to a given commit "%(is-base:<commit>)" is
likely based on.
- Comments?
+ Will merge to 'next'.
source: <pull.1768.v3.git.1723631490.gitgitgadget@gmail.com>
-* sj/ref-fsck (2024-08-08) 9 commits
- (merged to 'next' on 2024-08-09 at 3bde10da94)
- + fsck: add ref name check for files backend
- + files-backend: add unified interface for refs scanning
- + builtin/refs: add verify subcommand
- + refs: set up ref consistency check infrastructure
- + fsck: add refs report function
- + fsck: add a unified interface for reporting fsck messages
- + fsck: make "fsck_error" callback generic
- + fsck: rename objects-related fsck error functions
- + fsck: rename "skiplist" to "skip_oids"
-
- "git fsck" infrastructure has been taught to also check the sanity
- of the ref database, in addition to the object database.
-
- Will merge to 'master'.
- source: <ZrSqMmD-quQ18a9F@ArchLinux.localdomain>
-
-
* cc/promisor-remote-capability (2024-07-31) 4 commits
- promisor-remote: check advertised name or URL
- Add 'promisor-remote' capability to protocol v2
remotes it uses, so that the server side can omit objects that the
client can lazily obtain from these other promissor remotes.
- Comments?
+ Expecting a reroll.
+ cf. <ZrDYIFolRlERFdUT@tanuki>
source: <20240731134014.2299361-1-christian.couder@gmail.com>
-* tb/incremental-midx-part-1 (2024-08-06) 19 commits
- (merged to 'next' on 2024-08-12 at 92ec55fd49)
- + midx: implement support for writing incremental MIDX chains
- + t/t5313-pack-bounds-checks.sh: prepare for sub-directories
- + t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
- + midx: implement verification support for incremental MIDXs
- + midx: support reading incremental MIDX chains
- + midx: teach `midx_fanout_add_midx_fanout()` about incremental MIDXs
- + midx: teach `midx_preferred_pack()` about incremental MIDXs
- + midx: teach `midx_contains_pack()` about incremental MIDXs
- + midx: remove unused `midx_locate_pack()`
- + midx: teach `fill_midx_entry()` about incremental MIDXs
- + midx: teach `nth_midxed_offset()` about incremental MIDXs
- + midx: teach `bsearch_midx()` about incremental MIDXs
- + midx: introduce `bsearch_one_midx()`
- + midx: teach `nth_bitmapped_pack()` about incremental MIDXs
- + midx: teach `nth_midxed_object_oid()` about incremental MIDXs
- + midx: teach `prepare_midx_pack()` about incremental MIDXs
- + midx: teach `nth_midxed_pack_int_id()` about incremental MIDXs
- + midx: add new fields for incremental MIDX chains
- + Documentation: describe incremental MIDX format
- (this branch is used by jk/midx-unused-fix and tb/incremental-midx-part-2.)
-
- Incremental updates of multi-pack index files.
-
- Will merge to 'master'.
- source: <cover.1722958595.git.me@ttaylorr.com>
-
-
* ja/doc-synopsis-markup (2024-08-12) 3 commits
- doc: apply synopsis simplification on git-clone and git-init
- doc: update the guidelines to reflect the current formatting rules
been revamped. The sources, at least for the simple cases, got
vastly pleasant to work with.
- Comments?
+ Will merge to 'next'?
+ cf. <xmqqzfp8cm30.fsf@gitster.g>
source: <pull.1766.v3.git.1723389612.gitgitgadget@gmail.com>
Expecting a reroll.
cf. <ZqC82sDnj7Se_aVB@tanuki>
source: <20240715003519.2671385-1-e@80x24.org>
-
-
-* rs/unit-tests-test-run (2024-07-30) 6 commits
- (merged to 'next' on 2024-08-12 at 9df4336877)
- + t-strvec: use if_test
- + t-reftable-basics: use if_test
- + t-ctype: use if_test
- + unit-tests: add if_test
- + unit-tests: show location of checks outside of tests
- + t0080: use here-doc test body
-
- Unit-test framework has learned a simple control structure to allow
- embedding test statements in-line instead of having to create a new
- function to contain them.
-
- Will merge to 'master'.
- source: <077a178e-eb30-45ff-b653-a514bfd33077@web.de>
projects / thirdparty / git.git / commitdiff
