]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
RISC-V: Fix VSETVL VL check condition bug
authorJuzhe-Zhong <juzhe.zhong@rivai.ai>
Wed, 8 Nov 2023 11:33:06 +0000 (19:33 +0800)
committerPan Li <pan2.li@intel.com>
Wed, 8 Nov 2023 11:38:00 +0000 (19:38 +0800)
When fixing the induction variable vectorization bug, notice there is a ICE bug
in VSETVL PASS:

0x178015b rtl_check_failed_code1(rtx_def const*, rtx_code, char const*, int, char const*)
        ../../../../gcc/gcc/rtl.cc:770
0x1079cdd rhs_regno(rtx_def const*)
        ../../../../gcc/gcc/rtl.h:1934
0x1dab360 vsetvl_info::parse_insn(rtl_ssa::insn_info*)
        ../../../../gcc/gcc/config/riscv/riscv-vsetvl.cc:1070
0x1daa272 vsetvl_info::vsetvl_info(rtl_ssa::insn_info*)
        ../../../../gcc/gcc/config/riscv/riscv-vsetvl.cc:746
0x1da5d98 pre_vsetvl::fuse_local_vsetvl_info()
        ../../../../gcc/gcc/config/riscv/riscv-vsetvl.cc:2708
0x1da94d9 pass_vsetvl::lazy_vsetvl()
        ../../../../gcc/gcc/config/riscv/riscv-vsetvl.cc:3444
0x1da977c pass_vsetvl::execute(function*)
        ../../../../gcc/gcc/config/riscv/riscv-vsetvl.cc:3504

Committed as it is obvious.

gcc/ChangeLog:

* config/riscv/riscv-vsetvl.cc: Fix ICE.

gcc/testsuite/ChangeLog:

* gcc.target/riscv/rvv/base/vl-use-ice.c: New test.

gcc/config/riscv/riscv-vsetvl.cc
gcc/testsuite/gcc.target/riscv/rvv/base/vl-use-ice.c [new file with mode: 0644]

index 77dbf159d411a5f02d964c01c9e7b6f39e38dea1..3fa25a6404de4725e0be527873d23a20634f197d 100644 (file)
@@ -1067,7 +1067,7 @@ public:
                break;
              }
            rtx avl = ::get_avl (rinsn);
-           if (!avl || REGNO (get_vl ()) != REGNO (avl))
+           if (!avl || !REG_P (avl) || REGNO (get_vl ()) != REGNO (avl))
              {
                m_vl_used_by_non_rvv_insn = true;
                break;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/vl-use-ice.c b/gcc/testsuite/gcc.target/riscv/rvv/base/vl-use-ice.c
new file mode 100644 (file)
index 0000000..715c7e0
--- /dev/null
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-O3 -march=rv64gcv -mabi=lp64d" } */
+
+#include "riscv_vector.h"
+
+void foo(void *in1, void *out, size_t avl) {
+
+  size_t vl = __riscv_vsetvl_e32m1(avl);
+  vint32m1_t v = __riscv_vmv_v_x_i32m1 (vl, 16);
+  __riscv_vse32_v_i32m1 (out, v, 16);
+}