]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
spapr: set vsmt to MAX(8, smp_threads)
authorLaurent Vivier <lvivier@redhat.com>
Fri, 9 Feb 2018 08:18:58 +0000 (09:18 +0100)
committerGreg Kurz <groug@kaod.org>
Tue, 22 May 2018 10:58:59 +0000 (12:58 +0200)
We ignore silently the value of smp_threads when we set
the default VSMT value, and if smp_threads is greater than VSMT
kernel is going into trouble later.

Fixes: 8904e5a750
("spapr: Adjust default VSMT value for better migration compatibility")

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
(cherry picked from commit 4ad64cbd0c3f9df15be5f7d1c920285551e802ca)
Signed-off-by: Greg Kurz <groug@kaod.org>
hw/ppc/spapr.c

index 0c6547faef7d051431a293d42961975f3d3e4503..6f78c1cf7a830e1398047f8688179b24732a0853 100644 (file)
@@ -2289,7 +2289,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *spapr, Error **errp)
          * the value that we'd get with KVM on POWER8, the
          * overwhelmingly common case in production systems.
          */
-        spapr->vsmt = 8;
+        spapr->vsmt = MAX(8, smp_threads);
     }
 
     /* KVM: If necessary, set the SMT mode: */