]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
watchdog: imx2_wdt: Fix set_timeout for big timeout values
authorGeorg Hofmann <georg@hofmannsweb.com>
Mon, 8 Apr 2019 19:25:54 +0000 (21:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:53 +0000 (11:54 +0200)
[ Upstream commit b07e228eee69601addba98b47b1a3850569e5013 ]

The documentated behavior is: if max_hw_heartbeat_ms is implemented, the
minimum of the set_timeout argument and max_hw_heartbeat_ms should be used.
This patch implements this behavior.
Previously only the first 7bits were used and the input argument was
returned.

Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/watchdog/imx2_wdt.c

index 518dfa1047cbd584d692930da7467d643c109a42..5098982e1a585f1fbde452b22eb9179f8c0a6b49 100644 (file)
@@ -181,8 +181,10 @@ static void __imx2_wdt_set_timeout(struct watchdog_device *wdog,
 static int imx2_wdt_set_timeout(struct watchdog_device *wdog,
                                unsigned int new_timeout)
 {
-       __imx2_wdt_set_timeout(wdog, new_timeout);
+       unsigned int actual;
 
+       actual = min(new_timeout, wdog->max_hw_heartbeat_ms * 1000);
+       __imx2_wdt_set_timeout(wdog, actual);
        wdog->timeout = new_timeout;
        return 0;
 }