]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
f2fs: fix the wrong f2fs_bug_on condition in f2fs_do_replace_block
authorLongPing Wei <weilongping@oppo.com>
Mon, 21 Oct 2024 02:31:47 +0000 (10:31 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 1 Nov 2024 01:19:01 +0000 (01:19 +0000)
This f2fs_bug_on was introduced by commit 2c1905042c8c ("f2fs: check
segment type in __f2fs_replace_block") when there were only 6 curseg types.
After commit d0b9e42ab615 ("f2fs: introduce inmem curseg") was introduced,
the condition should be changed to checking curseg->seg_type.

Fixes: d0b9e42ab615 ("f2fs: introduce inmem curseg")
Signed-off-by: LongPing Wei <weilongping@oppo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/segment.c

index 216762a10e5a677317fde503d411ba18ac0f156d..96e7abaf42c818695835ed79d231cea3f51aa199 100644 (file)
@@ -3978,8 +3978,8 @@ void f2fs_do_replace_block(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
                }
        }
 
-       f2fs_bug_on(sbi, !IS_DATASEG(type));
        curseg = CURSEG_I(sbi, type);
+       f2fs_bug_on(sbi, !IS_DATASEG(curseg->seg_type));
 
        mutex_lock(&curseg->curseg_mutex);
        down_write(&sit_i->sentry_lock);