]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: mux-h2: remove useless test on stream ID vs last in wake function
authorWilly Tarreau <w@1wt.eu>
Tue, 7 May 2019 12:44:41 +0000 (14:44 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 14 May 2019 13:47:57 +0000 (15:47 +0200)
h2_wake_some_streams() first looks up streams whose IDs are greater than
or equal to last+1, then checks if the id is lower than or equal to last,
which by definition will never match. Let's remove this confusing leftover
from ancient code.

src/mux_h2.c

index c4588eec52d03b7232b9f2ed3c4489e669c6477f..40ff11a7e715227cf4c51f16d68ffccded92dd86 100644 (file)
@@ -1464,8 +1464,6 @@ static void h2_wake_some_streams(struct h2c *h2c, int last, uint32_t flags)
        node = eb32_lookup_ge(&h2c->streams_by_id, last + 1);
        while (node) {
                h2s = container_of(node, struct h2s, by_id);
-               if (h2s->id <= last)
-                       break;
                node = eb32_next(node);
                h2s_wake_one_stream(h2s, flags);
        }