]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HSI: omap-ssi: Remove unnecessary debugfs_create_dir() error check
authorYang Ruibin <11162571@vivo.com>
Tue, 27 Aug 2024 12:08:16 +0000 (20:08 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 27 Aug 2024 13:28:56 +0000 (15:28 +0200)
Remove the debugfs_create_dir() error check. It's safe to pass in error
pointers to the debugfs API, hence the user isn't supposed to include
error checking of the return values.

Signed-off-by: Yang Ruibin <11162571@vivo.com>
Link: https://lore.kernel.org/r/20240827120816.3910198-1-11162571@vivo.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/hsi/controllers/omap_ssi_core.c

index 3140990a61644e43b27a3030da074b9dffaba269..15cb759151e66991524c594ded1fc4212e973972 100644 (file)
@@ -116,22 +116,13 @@ static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
 
        /* SSI controller */
        omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL);
-       if (!omap_ssi->dir)
-               return -ENOMEM;
+       debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi, &ssi_regs_fops);
 
-       debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi,
-                                                               &ssi_regs_fops);
        /* SSI GDD (DMA) */
        dir = debugfs_create_dir("gdd", omap_ssi->dir);
-       if (!dir)
-               goto rback;
        debugfs_create_file("regs", S_IRUGO, dir, ssi, &ssi_gdd_regs_fops);
 
        return 0;
-rback:
-       debugfs_remove_recursive(omap_ssi->dir);
-
-       return -ENOMEM;
 }
 
 static void ssi_debug_remove_ctrl(struct hsi_controller *ssi)