]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/dsi: Fix off by one in BXT_MIPI_TRANS_VTOTAL
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 14 Mar 2025 15:01:34 +0000 (17:01 +0200)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 16 Jun 2025 04:57:00 +0000 (07:57 +0300)
BXT_MIPI_TRANS_VTOTAL must be programmed with vtotal-1
instead of vtotal. Make it so.

Cc: stable@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250314150136.22564-1-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit 7b3685c9b38c3097f465efec8b24dbed63258cf6)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/display/vlv_dsi.c

index 346737f15fa93264ab8791912cc4cc128f2f3324..21c1e10caf684637b36fbe84752e8216bcaca406 100644 (file)
@@ -1056,7 +1056,7 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
                                              BXT_MIPI_TRANS_VACTIVE(port));
        adjusted_mode->crtc_vtotal =
                                intel_de_read(display,
-                                             BXT_MIPI_TRANS_VTOTAL(port));
+                                             BXT_MIPI_TRANS_VTOTAL(port)) + 1;
 
        hactive = adjusted_mode->crtc_hdisplay;
        hfp = intel_de_read(display, MIPI_HFP_COUNT(display, port));
@@ -1260,7 +1260,7 @@ static void set_dsi_timings(struct intel_encoder *encoder,
                        intel_de_write(display, BXT_MIPI_TRANS_VACTIVE(port),
                                       adjusted_mode->crtc_vdisplay);
                        intel_de_write(display, BXT_MIPI_TRANS_VTOTAL(port),
-                                      adjusted_mode->crtc_vtotal);
+                                      adjusted_mode->crtc_vtotal - 1);
                }
 
                intel_de_write(display, MIPI_HACTIVE_AREA_COUNT(display, port),